search

eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

Remove of the MoDisco EPackage view and of the metamodel browsing button #621

Closed eclipse-modisco-bot closed 2 hours ago

eclipse-modisco-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 333651 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Jan 06, 2011 08:44 EDT | | Modified | Jan 11, 2011 09:25 EDT | | Version | 0.9.0 | | Depends on | 333652 | | Reporter | Gregoire Dupe |

Description

Hello,

Since the MoDisco EPackage view and the metamodel browsing button have been copied in EMF Facet, they have to be removed from MoDisco.

An extension point offering the possibility to declare an EPackage browser is needed to be able to use the MoDisco browser to display the meta-models.

MoDisco has to declare an extension to this extension point.

Regards,\ Gregoire Dupe

eclipse-modisco-bot commented 2 hours ago

By Nicolas Guyomar on Jan 07, 2011 11:56

Created attachment 186290 Bug 333651

Hi,

Please find attached the code modification to meet the requirements of this bug.

(a) I, Nicolas Guyomar, wrote 100% of the code of the patch. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL.

Regards

Nicolas Guyomar

:notepad_spiral: Bug 333651.patch

eclipse-modisco-bot commented 2 hours ago

By Gregoire Dupe on Jan 11, 2011 05:25

Hello,

Here are contributions from an employee of Mia-Software, targeting future\ Indigo release. The company has signed a Member Commiter Agreement. The\ contribution does not need a CQ (see bug 322327).

Regards,\ Gregoire

eclipse-modisco-bot commented 2 hours ago

By Gregoire Dupe on Jan 11, 2011 06:07

I’ve committed the Nicolas Guyomar’s patch.

This patch removes the classes OpenModelFromEmfRegistryAction, UriSelectionDialog, PackageRegistryView because those classes have been copied to EMF Facet.

The use of the MoDisco browser to open EPackage from the EMF Facet’s view is possible thanks to the use of the extension point org.eclipse.emf.facet.util.emf.ui.epackagebrower and the class org.eclipse.gmt.modisco.infra.browser.epackagebrowserEPackageBrowser.

The releng project has been updated because the patch creates a dependency to the EMF Facet project.

eclipse-modisco-bot commented 2 hours ago

By Gregoire Dupe on Jan 11, 2011 06:27

Committed revision 3713.

eclipse-modisco-bot commented 2 hours ago

By Gregoire Dupe on Jan 11, 2011 09:25

It works with EMF Facet 0.1.0.v201101101615 and MoDisco 0.9.0.v201101111211.

Regards,\ Gregoire Dupe