search

eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0
0 stars 0 forks source link

intermittent JUnit failures on JSP tests #691

Closed eclipse-modisco-bot closed 1 day ago

eclipse-modisco-bot commented 1 day ago

| --- | --- | | Bugzilla Link | 341193 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Mar 29, 2011 03:44 EDT | | Modified | Aug 18, 2011 08:01 EDT | | Version | 0.9.0 | | Depends on | 341596 | | Reporter | Nicolas Bros |

Description

I've seen the following two JSP tests get stuck randomly, causing a build timeout:\ org.eclipse.modisco.jee.jsp.discoverer.tests.compatibility.TestHtml.test1\ org.eclipse.modisco.jee.jsp.discoverer.tests.compatibility.TestJsp.test1

For TestHtml.test1, this might be due to the fact that the JSP references an external DTD:\ http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd\ So, network issues on the build server may cause this.

But for TestJsp.test1, I don't see any external reference in "jspElement.jsp".

eclipse-modisco-bot commented 1 day ago

By Nicolas Bros on Apr 01, 2011 04:46

(In reply to comment #0)

For TestHtml.test1, this might be due to the fact that the JSP references an external DTD: http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd So, network issues on the build server may cause this.

I have verified on my PC using Fiddler, and launching the JUnit test doesn't seem to cause any network access. But this might be because it's already cached on my PC?

eclipse-modisco-bot commented 1 day ago

By Nicolas Bros on Apr 01, 2011 05:43

With these modifications, the code running at the time of the timeout appears in the log. It appears to be in:

org.eclipse.acceleo.common.utils.CompactLinkedHashSet.deleteIndex(int index)

Where a while loop is running until a condition is met. And apparently this condition is never met, causing an infinite loop.

The call to the Acceleo code seems to be caused by a workspace change notification while deleting a Resource in the test.

eclipse-modisco-bot commented 1 day ago

By Nicolas Bros on Apr 05, 2011 05:29

I haven't seen any JSP test timeouts since I switched to the nightly Acceleo update site, which incorporates a supposed fix.\ So, I'm marking this bug as fixed.

eclipse-modisco-bot commented 1 day ago

By Hugo Bruneliere on Aug 18, 2011 08:01

Bug solved.