Eclipse 4.2 crash when creating a new facet model

[eclipse-modisco-bot]

| --- | --- | | Bugzilla Link | 376699 | | Status | CLOSED FIXED | | Importance | P2 blocker | | Reported | Apr 13, 2012 05:15 EDT | | Modified | Apr 30, 2013 09:26 EDT | | Version | 0.10.0 | | Reporter | Missing name |

Description

i've tried to create a new facet model in Eclipse 4.2

i always have a crash.

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 05:38

I can reproduce this bug.

It caused by the fact that PlatformUI.getWorkbench().getSharedImages() .getImage(ISharedImages.IMG_DEC_FIELD_ERROR) returns null with Eclipse 4.2.

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 05:41

Created attachment 216757 Patch fixing this bug

(a) I, Gregoire Dupe, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features.

:notepad_spiral: bug376699.patch.txt

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 05:43

Created attachment 216758 A red cross icon

Here is an icon replacing the missing one.

(a) I, Gregoire Dupe, wrote 100% of the code I've provided. (b) I have the right to contribute the code to Eclipse. (c) I contribute the content under the EPL. (d) This contribution contains no Cryptography features.

error.PNG

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 05:47

I've proposed a patch providing a dedicated icon.

To my mind this patch must be committed in 0.10.0RC3 to avoid Eclipse crashes when opening a facetSet editor.

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 07:39

Hello Kenn,

To my mind this patch must be committed in 0.10.0RC3 to avoid Eclipse crashes\ when opening a facetSet editor.

Regards,\ Grégoire

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 10:56

Comment on attachment 216757 Patch fixing this bug

I've committed this patch Committed revision 4938.

:notepad_spiral: bug376699.patch.txt

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 10:56

Comment on attachment 216758 A red cross icon

I've committed this icon. Committed revision 4938.

error.PNG

[eclipse-modisco-bot]

By Gregoire Dupe on Jun 04, 2012 10:57

This bug can be marked as fixed.

[eclipse-modisco-bot]

By Hugo Bruneliere on Jun 04, 2012 11:36

Issue solved.

[eclipse-modisco-bot]

By Hugo Bruneliere on Feb 06, 2013 12:00

Issue fixed, bug can be closed.