Bug uiCustom with query

[eclipse-modisco-bot]

| --- | --- | | Bugzilla Link | 299277 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Jan 11, 2010 08:57 EDT | | Modified | May 23, 2011 08:55 EDT | | Version | 0.8.0 | | Blocks | 299406 | | Reporter | Nicolas Payneau |

Description

Build Identifier: 20090920-1017

Hi,

When a UI customization uses a query stored in a plug-in, we get the following error:

--------------------------------------------------------------------------------------------------------------\ eclipse.buildId=unknown\ java.version=1.6.0_13\ java.vendor=Sun Microsystems Inc.\ BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en\ Framework arguments: -product org.eclipse.epp.package.modeling.product\ Command-line arguments: -product org.eclipse.epp.package.modeling.product -data C:\nicolas_payneau\wokspaces\modisco_java_runtime3 -dev file:C:/nicolas_payneau/wokspaces/modisco_java/.metadata/.plugins/org.eclipse.pde.core/runtime3/dev.properties -debug C:\nicolas_payneau\wokspaces\modisco_java.metadata.plugins\org.eclipse.pde.core\runtime3/.options -os win32 -ws win32 -arch x86 -consoleLog

Error\ Mon Jan 11 14:47:21 CET 2010\ Failed to load the model query: modisco.infra.query.tests.01::test001

org.eclipse.gmt.modisco.infra.query.core.exception.ModelQueryException: Failed to load the model query: modisco.infra.query.tests.01::test001\ at org.eclipse.gmt.modisco.infra.query.core.java.JavaModelQueryFactory.create(JavaModelQueryFactory.java:133)\ at org.eclipse.gmt.modisco.infra.query.core.ModelQuerySetCatalog.getModelQueryImpl(ModelQuerySetCatalog.java:172)\ at org.eclipse.gmt.modisco.infra.browser.util.QueryUtil.basicEvaluate(QueryUtil.java:29)\ at org.eclipse.gmt.modisco.infra.browser.customization.CustomizationEngine.evaluate(CustomizationEngine.java:1087)\ at org.eclipse.gmt.modisco.infra.browser.customization.CustomizationEngine.getValue(CustomizationEngine.java:1070)\ at org.eclipse.gmt.modisco.infra.browser.customization.CustomizationEngine.getLabel(CustomizationEngine.java:683)\ at org.eclipse.gmt.modisco.infra.browser.customization.CustomizationEngine.getTypeLabel(CustomizationEngine.java:666)\ at org.eclipse.gmt.modisco.infra.browser.core.ModelElementItem.getDisplayName(ModelElementItem.java:412)\ at org.eclipse.gmt.modisco.infra.browser.core.ModelElementItem.getName(ModelElementItem.java:401)\ at org.eclipse.gmt.modisco.infra.browser.core.ModelElementItem.getText(ModelElementItem.java:395)\ at org.eclipse.gmt.modisco.infra.browser.editors.BrowserLabelProvider.getText(BrowserLabelProvider.java:38)\ at org.eclipse.jface.viewers.WrappedViewerLabelProvider.getText(WrappedViewerLabelProvider.java:108)\ at org.eclipse.jface.viewers.WrappedViewerLabelProvider.update(WrappedViewerLabelProvider.java:164)\ at org.eclipse.jface.viewers.ViewerColumn.refresh(ViewerColumn.java:145)\ at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:932)\ at org.eclipse.jface.viewers.AbstractTreeViewer$UpdateItemSafeRunnable.run(AbstractTreeViewer.java:102)\ at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)\ at org.eclipse.core.runtime.Platform.run(Platform.java:888)\ at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:48)\ at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)\ at org.eclipse.jface.viewers.AbstractTreeViewer.doUpdateItem(AbstractTreeViewer.java:1012)\ at org.eclipse.jface.viewers.StructuredViewer$UpdateItemSafeRunnable.run(StructuredViewer.java:481)\ at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)\ at org.eclipse.core.runtime.Platform.run(Platform.java:888)\ at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:48)\ at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)\ at org.eclipse.jface.viewers.StructuredViewer.updateItem(StructuredViewer.java:2111)\ at org.eclipse.jface.viewers.AbstractTreeViewer.createTreeItem(AbstractTreeViewer.java:827)\ at org.eclipse.jface.viewers.AbstractTreeViewer$1.run(AbstractTreeViewer.java:802)\ at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)\ at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:776)\ at org.eclipse.jface.viewers.TreeViewer.createChildren(TreeViewer.java:639)\ at org.eclipse.jface.viewers.AbstractTreeViewer.internalInitializeTree(AbstractTreeViewer.java:1490)\ at org.eclipse.jface.viewers.TreeViewer.internalInitializeTree(TreeViewer.java:828)\ at org.eclipse.jface.viewers.AbstractTreeViewer$5.run(AbstractTreeViewer.java:1474)\ at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1392)\ at org.eclipse.jface.viewers.TreeViewer.preservingSelection(TreeViewer.java:402)\ at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1353)\ at org.eclipse.jface.viewers.AbstractTreeViewer.inputChanged(AbstractTreeViewer.java:1467)\ at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:274)\ at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1634)\ at org.eclipse.gmt.modisco.infra.browser.editors.EcoreBrowser$MetaclassListViewerSelectionChangedListener.selectionChanged(EcoreBrowser.java:1089)\ at org.eclipse.jface.viewers.Viewer$2.run(Viewer.java:162)\ at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)\ at org.eclipse.core.runtime.Platform.run(Platform.java:888)\ at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:48)\ at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:175)\ at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:160)\ at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2132)\ at org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredViewer.java:1160)\ at org.eclipse.jface.viewers.StructuredViewer$4.widgetSelected(StructuredViewer.java:1190)\ at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent(OpenStrategy.java:228)\ at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:222)\ at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:389)\ at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)\ at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1003)\ at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3880)\ at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3473)\ at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2405)\ at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2369)\ at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2221)\ at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:500)\ at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)\ at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:493)\ at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)\ at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113)\ at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194)\ at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)\ at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)\ at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368)\ at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)\ at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\ at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)\ at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)\ at java.lang.reflect.Method.invoke(Unknown Source)\ at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:559)\ at org.eclipse.equinox.launcher.Main.basicRun(Main.java:514)\ at org.eclipse.equinox.launcher.Main.run(Main.java:1311)\ at org.eclipse.equinox.launcher.Main.main(Main.java:1287)\ Caused by: java.lang.NullPointerException\ at org.eclipse.gmt.modisco.infra.query.core.java.JavaModelQueryFactory.create(JavaModelQueryFactory.java:95) ... 78 more

---

You can find in attachment an example of customization (test.uiCustom) which doesn’t work.\ This customization use the queries contained and declared by the plug-in org.eclipse.gmt.modisco.infra.query.tests.

Best regards,

Nicolas Payneau

Reproducible: Always

[eclipse-modisco-bot]

By Nicolas Payneau on Jan 11, 2010 08:59

Created attachment 155739 The uiCustom file

test.uiCustom

[eclipse-modisco-bot]

By Gregoire Dupe on Jan 14, 2010 05:30

This bug is fixed.

The class CustomizationsCatalog must use "MoDiscoResourceSet.getResourceSetSingleton()" instead of "new ResourceSetImpl()".

Regards,\ Grégoire

[eclipse-modisco-bot]

By Hugo Bruneliere on Feb 02, 2010 04:32

Bug fixed