[Deprecated] org.eclipse.modisco.kdm.source.extension.ui.browser

eclipse-modisco / org.eclipse.modisco

Eclipse Public License 2.0

0 stars 0 forks source link

[Deprecated] org.eclipse.modisco.kdm.source.extension.ui.browser #980

Closed eclipse-modisco-bot closed 2 hours ago

eclipse-modisco-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 475243 | | Status | RESOLVED FIXED | | Importance | P2 enhancement | | Reported | Aug 18, 2015 05:25 EDT | | Modified | Mar 15, 2016 06:12 EDT | | Version | 0.13.0 | | See also | Gerrit change https://git.eclipse.org/r/54127, Git commit 08be41ae, Gerrit change https://git.eclipse.org/r/54221, Git commit e12ca030 | | Reporter | Gregoire Dupe |

Description

org.eclipse.modisco.kdm.source.extension.ui.browser.listener.ModelBrowserListener use a deprecated API.

eclipse-modisco-bot commented 2 hours ago

By Gregoire Dupe on Aug 18, 2015 05:59

The behavior implemented by 'ModelBrowserListener' is already implemented by 'org.eclipse.modisco.kdm.source.extension.ui.actions.ActionBrowseCodeInTextEditor'.

ActionBrowseCodeInTextEditor is accessible through a menu item and ModelBrowserListener through a double click.

ModelBrowserListener is binded to the extension point 'org.eclipse.gmt.modisco.infra.browser.doubleClickListener'. This is only use of the extension point in MoDisco.

eclipse-modisco-bot commented 2 hours ago

By Gregoire Dupe on Aug 18, 2015 08:20

To change the behavior of the MoDisco browser double click using an extension doesn't look to be a good idea :

With this extension point the user will never be able to know what will be action binded with the double click.
Two plug-ins can contribute a double click behavior for the same type, this implies to have a conflict solving user interface (may be a preference page).

Regarding those arguments I won't try to re-implement this extension to the new version of the model browser.

eclipse-modisco-bot commented 2 hours ago

By Gregoire Dupe on Aug 19, 2015 11:10

The whole plug-in can be removed.

eclipse-modisco-bot commented 2 hours ago

Aug 19, 2015 11:26

New Gerrit change created: https://git.eclipse.org/r/54127

eclipse-modisco-bot commented 2 hours ago

Aug 20, 2015 03:33

Gerrit change https://git.eclipse.org/r/54127 was merged to [maintenance-0.13].\ Commit: http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/commit/?id=08be41aeaf1870428b1504f81f678300b9f22529

eclipse-modisco-bot commented 2 hours ago

Aug 20, 2015 08:02

New Gerrit change created: https://git.eclipse.org/r/54221

eclipse-modisco-bot commented 2 hours ago

Aug 20, 2015 11:29

Gerrit change https://git.eclipse.org/r/54221 was merged to [rmDeprecated].\ Commit: http://git.eclipse.org/c/modisco/org.eclipse.modisco.git/commit/?id=e12ca030e5d1f22eab776e725b0ff171cf8ba18e