Fix pkgconfig libdir - Githubissues

nullr0ute commented 3 weeks ago

[X] Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
[X] Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
[ ] If you are contributing a new feature, is your work based off the develop branch?
[X] If you are contributing a bugfix, is your work based off the fixes branch?
[X] Have you added an explanation of what your changes do and why you'd like us to include them?
[X] Have you successfully run make test with your changes locally?

ralight commented 3 weeks ago

I understand the rationale, however at the moment the pure Makefile approach also installs the .pc files. This means there needs to be a string replacement when installing from Makefile otherwise it's completely broken there. Is there a better way of detecting the lib64 component?

nullr0ute commented 3 weeks ago

I understand the rationale, however at the moment the pure Makefile approach also installs the .pc files. This means there needs to be a string replacement when installing from Makefile otherwise it's completely broken there. Is there a better way of detecting the lib64 component?

I missed that the Makefile approach stole CMake vars in that approach, will update the patch so both ways are fixed.

eclipse-mosquitto / mosquitto

Fix pkgconfig libdir #3150