eclipse-mpc / epp.mpc

Eclipse Public License 2.0
2 stars 3 forks source link

Duplicate keyboard shortcut for Marketplace 'Find' input box and Installed tab #1

Closed jonahgraham closed 2 months ago

jonahgraham commented 11 months ago

Originally created in https://github.com/eclipse-packaging/packages/issues/64

The keyboard shortcut shown on the Eclipse Marketplace Search tab is the 'i' of 'Find'. However, when using that shortcut in Marketplace, the tab is changed to the 'Installed' tab.

Steps performed:

  1. Open Eclipse
  2. Select Help->Eclipse Marketplace...
  3. Click outside or move the focus out of the Search tab's 'Find' input box
  4. Use the keyboard shortkey, ALT+i

Expected behavior:

Actual behavior:

Suggested fixes:

jonahgraham commented 11 months ago

It seems these two accelerators are provided by different projects, the Installed seems to come from:

https://github.com/eclipse-mpc/epp.mpc/blob/031194d287be0c31140c5f781dc1b593ab11ebe7/org.eclipse.epp.mpc.ui/src/org/eclipse/epp/internal/mpc/ui/wizards/messages.properties#L103

But the Find comes from:

https://github.com/eclipse-equinox/p2/blob/fe258ce779cb3d13401f3ac71c0524e8ffbbf28d/bundles/org.eclipse.equinox.p2.ui.discovery/src/org/eclipse/equinox/internal/p2/ui/discovery/wizards/messages.properties#L18

For MPC changing the accelerator for Installed is probably easiest.