search

eclipse-mylyn / .github

Eclipse Public License 2.0
2 stars 2 forks source link

README: "Jump in" table second row lacks contrast #33

Open Chealer opened 1 year ago

Chealer commented 1 year ago

The README's Jump in section contains a table with 2 rows. The second row of that table looks empty, unless one looks closely or uses a traditional color scheme (black text on a white background). Each cell only contains one black (monochrome) image which―in dark mode―has almost no contrast with the almost black background, as "can be seen" in the following screenshot: image

Either the background's color should be set, or the image should not be monochrome.

By the way

- Using a 2-row table for this makes no sense. This should be a single-row table... or even better, an unordered list. - This section should come after the "Mylyn provides:" section. Basically, it should be in the _Developing and Contributing_ section. - The "Pull Requests" label is cryptic. This is visibly a "gitty way" (jargon) to refer to merge requests.

BeckerFrank commented 1 year ago

@wimjongman : Do you know where we can find a dark mode version of the used svg images (https://github.com/primer/octicons)

wimjongman commented 1 year ago

@Chealer Thanks for reporting! Are you able to provide a patch for the issues you mentioned?

Chealer commented 1 year ago

My "pleasure" @wimjongman The 3 "By the way" issues are mostly trivial, but the real bug isn't. I checked the project @BeckerFrank mentioned and indeed, finding a dark mode version is not easy... even though there seems to be one! Perhaps the icons used should be reevaluated. The icons for discussions and merge requests make much sense to me, but the one for issues doesn't help much in my opinion. As for the repositories icon, if you asked developers what it means out of context, I doubt 1% would even suggest that it represents repositories.

wimjongman commented 1 year ago

Thanks @Chealer! Yes, the icons can be replaced, and the repository icon is weird. If you have a suitable replacement icon, you can put it in the patch. I also just recently started porting the old wiki to the GitHub wiki. While you are at it, you could add a section in this table for the wiki. https://github.com/eclipse-mylyn/org.eclipse.mylyn/wiki