search

eclipse-mylyn / .github

Eclipse Public License 2.0
2 stars 2 forks source link

Update version numbers to 3.26.0 for features and bundles #7

Closed ruspl-afed closed 1 year ago

ruspl-afed commented 1 year ago

All the features should be aligned to version numbers to 3.26.0

ruspl-afed commented 1 year ago

We have an exception: org.eclipse.cdt.mylyn is already 5.22.0 and we cannot descrease it. But we can correct its name to org.eclipse.mylyn.cdt and give it version 3.26.0 And this change would be a kind of breaking. WDYT @wimjongman @BeckerFrank ?

wimjongman commented 1 year ago

Is that a feature or a plugin? I am not so much looking at plugin versions but at feature versions. At least, this is the strategy I follow for other projects. If all plugins are on the same version, we can consider a mass replace, otherwise, maybe only use the features as release number indicators. WDYT?

ruspl-afed commented 1 year ago

Is that a feature or a plugin?

https://github.com/eclipse-mylyn/org.eclipse.mylyn.context/blob/master/org.eclipse.mylyn.cdt-feature/feature.xml#L17

If all plugins are on the same version, we can consider a mass replace

This is exactly what I'm trying to achieve.

But we can correct its name to org.eclipse.mylyn.cdt and give it version 3.26.0

So, what about this proposal?

wimjongman commented 1 year ago

So, what about this proposal?

That sounds good to me but what about the old feature? Will we ditch it?

There are 6k references to it on Github: https://github.com/search?q=org.eclipse.cdt.mylyn&type=code

ruspl-afed commented 1 year ago

Will we ditch it? There are 6k references to it on Github

It seems we can't do this. Let's mark it deprecated and keep it for some years.

BeckerFrank commented 1 year ago

Here is the file which we use to update the versions /org.eclipse.mylyn.releng/bin/update-versions.sh so we can handle the different versions

ruspl-afed commented 1 year ago

Yes, I understand, we have a script that can process version update per repository. But I don't have a strong argument why do we need to support multiple versions in such coupled repositories with cross-references.

BeckerFrank commented 1 year ago

I only want to point you to that script so that you can find all the parts that need to be changed.

ruspl-afed commented 1 year ago

Seems to be done with known exceptions like CDT