Unable to Add GitHub Gist as Task Repository

emecas commented 4 months ago

Versions:

1) Eclipse IDE for Enterprise Java and Web Developers (includes Incubating components) Version: 2024-03 (4.31.0) Build id: 20240307-1437

2) Eclipse IDE for Enterprise Java and Web Developers 4.31.0.20240307-1200 epp.package.jee Eclipse Packaging Project

3) Mylyn Tasks Connector: GitHub 6.4.0.v20240209-1319 org.eclipse.mylyn.github.feature.feature.group Eclipse Mylyn

Problem :

I'm encountering an error when attempting to add a new task repository of type "GitHub Gist." Regardless of the URL format used, I receive the message: Enter a valid server URL.

Here are the specific URLs I've tried (replacing with my actual username):

https://gist.github.com (Base URL)
https://gist.github.com/<my-github-user> (My User Gists)
https://gist.github.com/<other-valid-github-user> (Another User's Gists)
https://gist.github.com/discover (Discover Gists)

Additionally, I have attempted using:

Valid user credentials (username and password)
Valid access token

Unfortunately, using any of these options prevents the expected functionality. The buttons "Validate Settings" and "Finish" remain disabled.

How to reproduce:

Go to the contextual menu in the Task List tab, then click New and then Query...

in the emergent dialog, click in Add Task Repository button, and then select from the list GitHub Gist and then click theNext button

Here is the problem

BeckerFrank commented 4 months ago

This is not easy to fix. We have taken over responsibility from another project. As far as I can see, the problem is that the gist URL is validated with org.eclipse.egit.github.core.RepositoryId.createFromUrl. Gist URLs have no owner and no name segment like repositories. I don't know how this has ever worked.

emecas commented 4 months ago

This is not easy to fix. We have taken over responsibility from another project.

Do you mean that you are barely taking ownership of this project, I guess?

As far as I can see, the problem is that the gist URL is validated with org.eclipse.egit.github.core.RepositoryId.createFromUrl. Gist URLs have no owner and no name segment like repositories.

Where is the code you are referring too Here? I would like to take a look, may you facilitate a link?

I don't know how this has ever worked.

@BeckerFrank thank you for following up on the subject. It was my first time trying to use it. Maybe they made it available but non-functional

emecas commented 2 months ago

@BeckerFrank thank you for the fix, I saw you closed this and labeled for 4.3.0 , any idea when it is going to be available?

BeckerFrank commented 2 months ago

@BeckerFrank thank you for the fix, I saw you closed this and labeled for 4.3.0 , any idea when it is going to be available?

The change was in Commit https://github.com/eclipse-mylyn/org.eclipse.mylyn/commit/58da8beda7f73e6c7eaf842bb78442500787ccd5 and is part of the now available Version 4.3.0. If not please open a new Issue.

emecas commented 2 months ago

@BeckerFrank thank you for the fix, I saw you closed this and labeled for 4.3.0 , any idea when it is going to be available?

The change was in Commit 58da8be and is part of the now available Version 4.3.0. If not please open a new Issue.

Verified, it is working, I had to upgrade to 2024-06 (4.32.0) Build id: 20240606-1231, Thanks @BeckerFrank again for the fix!!

eclipse-mylyn / org.eclipse.mylyn