search

eclipse-mylyn / org.eclipse.mylyn

Eclipse Public License 2.0
13 stars 9 forks source link

Disable integration tests that need mylyn.org #504 #505

Closed BeckerFrank closed 4 months ago

BeckerFrank commented 4 months ago

Task-Url: https://github.com/eclipse-mylyn/org.eclipse.mylyn/issues/504

BeckerFrank commented 4 months ago

@gnl42: We have tests that are running, but also an @Ignore("No CI Server"). Any ideas?

gnl42 commented 4 months ago

I'll have to take a look when I get home.

How is it that maven reports a successful build when there are failures?

BeckerFrank commented 4 months ago

I'll have to take a look when I get home.

How is it that maven reports a successful build when there are failures?

The maven build is unstable with 10 failing org.eclipse.mylyn.commons tests.

BeckerFrank commented 4 months ago

I'll have to take a look when I get home. How is it that maven reports a successful build when there are failures?

Found that we have the following two lines in the Jenkins File.

-Dmaven.test.failure.ignore=true \
-Dmaven.test.error.ignore=true \
ruspl-afed commented 4 months ago

It seems that we have nothing to contribute for 2024-06 M2, let try to solve this one in the nearest time to have a green build for 2024-06 M3 FYI @merks

merks commented 4 months ago

Thank you for keeping me informed.

gnl42 commented 4 months ago

Sigh, its JUnit 3 vs JUnit 4. @Ignore doesn't do anything when the class extends TestCase. Have to convert to JUnit 4 and @Test

gnl42 commented 4 months ago

No errors, but haven't had a chance to look closer at what was run. Tomorrows problem

BeckerFrank commented 4 months ago

Actual we skip Network Tests for Jenkins. But Class JenkinsValidationTest did not need the CI Server so we maybe can activate the two unit tests. Thoughts?

gnl42 commented 4 months ago

No luck, JenkinsValidationTest needs a Jenkins server to work

ruspl-afed commented 4 months ago

Thank you for bringing Mylyn pipeline back to life @gnl42 @BeckerFrank !