eclipse-mylyn / org.eclipse.mylyn

Eclipse Public License 2.0
13 stars 9 forks source link

306 replace guava mediatype #516

Closed gnl42 closed 4 months ago

gnl42 commented 4 months ago

Replace guavas MediaType

two down, one to go

gnl42 commented 4 months ago

@ruspl-afed Any chance you have 'ignore white space' disabled? image

ruspl-afed commented 4 months ago

@ruspl-afed Any chance you have 'ignore white space' disabled?

Yes, this is how I was able to look at the distilled change.

merks commented 4 months ago

FYI, the changes here introduced a new dependency on org.apache.tika.core which needs to be in the update site:

https://github.com/eclipse-mylyn/org.eclipse.mylyn/pull/518

ruspl-afed commented 4 months ago

FYI, the changes here introduced a new dependency on org.apache.tika.core which needs to be in the update site:

518

Right, I forgot that we need to add every introduced 3rd party bundle to category.xml

merks commented 4 months ago

@ruspl-afed @gnl42

BTW, I noticed these are available newer versions

These are distributed as OSGi bundles and would be trivial to add to Orbit. It would make more sense to add the 2.x version rather than the 1.x version though. Would it make sense to add the 2.x version and test that it's a good replacement?

gnl42 commented 4 months ago

Go for 2.x

ruspl-afed commented 4 months ago

Go for 2.x

gnl42 commented 3 months ago

@merks Could you remind me how I can get apache commons-text added to Orbit?

merks commented 3 months ago

Open an issue here and ask nicely 😇

https://github.com/eclipse-orbit/orbit-simrel/issues

merks commented 3 months ago

Of course it pays off to see what's already there:

image

The tabular summary is quite helpful:

https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/table.html

gnl42 commented 3 months ago

Assuming one even remembers that there is a milestone :)

The summary is exactly what I was about to ask for

Thanks