search

eclipse-mylyn / org.eclipse.mylyn

Eclipse Public License 2.0
13 stars 9 forks source link

Remove guava in wikitext, Part 1 #521 #530

Closed gnl42 closed 4 weeks ago

gnl42 commented 2 months ago

Replace basic guava constructs with Java 17/Apache commons equivalents

gnl42 commented 1 month ago

Can I merge this now, or should I wait for 4.3.0 to be released?

BeckerFrank commented 1 month ago

Can I merge this now, or should I wait for 4.3.0 to be released?

I think it depends on how we handle https://github.com/eclipse-mylyn/org.eclipse.mylyn/issues/354 (also planned for 4.3). For me it is Ok to merge this after resolving the conflicts.

ruspl-afed commented 1 month ago

Too risky for 4.3.0, we have not more than 3 days to produce final bits

ruspl-afed commented 4 weeks ago

Do you think we can remove unrelated changes from this PR @gnl42 ? There are a lot of changed line ends.

gnl42 commented 4 weeks ago

Sigh, what are they doing back. I cleaned up all that.

Use 'Hide whitespace'

gnl42 commented 4 weeks ago

Wrecken fracken. Just realized what I did. I removed them from the commit because they only had white space changes. I should have left them in because of the line ending update a while ago.

I'll redo the merge