Improve the Oomph setup and m2e launchers

eclipse-mylyn / org.eclipse.mylyn

Eclipse Public License 2.0

13 stars 9 forks source link

Improve the Oomph setup and m2e launchers #546

Closed merks closed 1 month ago

merks commented 1 month ago

Specify property user.home=${system_property:user.home} for the m2e launchers so that the user.home of the launched process necessarily matches the user.home of the launching application.
Add a preference task to show Oomph's tiny two-button setup tool bar.
Set the eclipse.target.platform variable to None to avoid a prompt for something not intended to be used.
Set IDs on tasks that are reference to avoid references that are positional which might be corrupted by textual editing.
Configure clones configure new branches to rebase.
Configure core/autocrlf to input.
Set the console to be of unlimited outputsize with tab width of 4.

merks commented 1 month ago

It strikes me that this setting is just asking for trouble:

With this setting it's easy to accidentally commit text files with \r\n into the git repository.

Are you folks sure that this would not be better set to input rather than false? That way \n is not converted to \r\n on checkout, but \r\n is converted to \n on check-in (input)...

merks commented 1 month ago

I'm out for a while now....

BeckerFrank commented 1 month ago

It strikes me that this setting is just asking for trouble:

With this setting it's easy to accidentally commit text files with \r\n into the git repository.

Are you folks sure that this would not be better set to input rather than false? That way \n is not converted to \r\n on checkout, but \r\n is converted to \n on check-in (input)...

Yes we should change this setting! Do you add an other commit to your branch?

merks commented 1 month ago

I’ll amend and force push when I get home.

merks commented 1 month ago

I believe all these files are committed with wrong line endings:

Just download the raw file and have a look:

https://raw.githubusercontent.com/eclipse-mylyn/org.eclipse.mylyn/main/mylyn.reviews/tbr/org.eclipse.mylyn.reviews.tasks.dsl/.classpath

I can create a PR to fix this once this is done...

merks commented 1 month ago

This PR includes the requested change from:

https://github.com/eclipse-mylyn/org.eclipse.mylyn/pull/543#issuecomment-2143532560

merks commented 1 month ago

I think there is nothing controversial here and most certainly nothing that can't be changed.