search

eclipse-mylyn / org.eclipse.mylyn

Eclipse Public License 2.0
13 stars 9 forks source link

Use org.glassfish.hk2.osgi-resource-locator from latest Orbit #569

Closed merks closed 2 weeks ago

merks commented 2 weeks ago

https://github.com/eclipse-simrel/simrel.build/issues/438

The 2.5.0 versions are all older than the 1.0.3 version:

https://repo1.maven.org/maven2/org/glassfish/hk2/osgi-resource-locator/

merks commented 2 weeks ago

@gnl42 @BeckerFrank @ruspl-afed

Guys, I assume you have no concerns about this trivial change...

merks commented 2 weeks ago

LGTM However having 1.0.3 newer than any 2.x is not so trivial

I didn't actually test what the build produces, only how the *.target resolves in the IDE. How Tycho does it versus how PDE does it might be two different answers. I shall check now locally. The target might have to specify an exact version...

merks commented 2 weeks ago

@ruspl-afed

I tested at locally it has the 1.0.3 version in the repository:

image

So it appears the trivial change has the intended effect. Is there some other concern I've overlooked?

ruspl-afed commented 2 weeks ago

Is there some other concern I've overlooked?

None from my side. Thank you @merks

merks commented 2 weeks ago

Very good. I will given the other folks a bit more time, but I don't think there's anything controversial here. 😀