search

eclipse-n4js / n4js

Eclipse Public License 1.0
33 stars 24 forks source link

Fix subtype check on identical type refs #2048

Closed mmews-n4 closed 3 years ago

mmews-n4 commented 3 years ago

At the moment, subtype checks on identical type refs (i.e. actually the same Java reference in the VM to a type) causes a complete check to be executed. Adding a shortcut for this corner case saves 30+ seconds on OPR.

mor-n4 commented 3 years ago

Just for reference: this short-cut would not have saved much build time in OPR until a few days ago when code changes were introduced that now cause an extensive amount of additional structural subtype checking. In other words, the actual problem lies in structural subtype checking and this short-cut is just a quick fix. See GH-2047 for further investigation.