search

eclipse-nattable / nattable

High performance SWT data grid
https://eclipse.dev/nattable/
Eclipse Public License 2.0
11 stars 6 forks source link

Replace javax.inject with jakarta.inject #91

Closed grozadanut closed 4 weeks ago

grozadanut commented 1 month ago

Eclipse version starting with 2024-03 (4.31.0) dropped support for javax.inject package. It needs to be replaced with jakarta.inject. org.eclipse.nebula.widgets.nattable.extension.e4 still has a dependency to javax.inject so it cannot be used with the new eclipse version.

Provided a patch for these changes: nattable.patch

fipro78 commented 1 month ago

Thanks for the report and the patch. But I do not agree completely.

  1. The statement Eclipse version starting with 2024-03 (4.31.0) dropped support for javax.inject package is not correct. From 4.30 the Jakarta annotations are supported and it is recommended to migrate. There is a deprecation period of at least two years (see Eclipse Project 4.30 New and Noteworthy - Support for Jakarta Annotations by Eclipse E4). So while I agree that we should migrate, there is no pressure. And I also need to consider users of NatTable that are not yet able to switch to the newest Eclipse version.
  2. As a GitHub project we do not accept patch files attached to an issue. Please follow the GitHub process and create a pull request. But because of the above reason I am not willing to merge it soon.
grozadanut commented 4 weeks ago

Indeed it seems that adding jakarta.inject.jakarta.inject-api version="1.0.5" to the target platform seems to make it work. A bit misleading as I was searching for a javax plugin, not jakarta.

Anyway, adding a pull request now seems unnecessary, since it won't be merged in the near future, and the change is a two-liner. Closing the issues for now. Thank you!