[ui] Use common OCL parent for all menu entries

[eclipse-ocl-bot]

| --- | --- | | Bugzilla Link | 425541 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Jan 13, 2014 05:46 EDT | | Modified | May 25, 2015 17:21 EDT | | Reporter | Ed Willink |

Description

As a small contribution to Eclipse IDE integrity, it would be good to move all\ general purpose OCL menu entries to be OCL->... so that there is never more\ than one top level OCL entry. So "OCL->Load Document..." rather than "Load\ Complete OCL Resource...".

NB Documentation/Wiki references.

[eclipse-ocl-bot]

By Ed Willink on Jan 18, 2014 09:11

Common Menu and Common Views Category pushed to master for M5.

[eclipse-ocl-bot]

By marwa rostren on Feb 11, 2014 08:36

Seems that OCL menu is not available for custom models (e.g model.mymodel)

[eclipse-ocl-bot]

By Ed Willink on Feb 11, 2014 09:53

Problem is that EMF generates a custom menu name.

Either raise a Bugzilla or add an entry to your custom model.

I'm reluctant to add an all-menus and a custom property tester everywhere.

[eclipse-ocl-bot]

By marwa rostren on Feb 12, 2014 04:25

How can I add my entry and what generic contribution I have to call ?

[eclipse-ocl-bot]

By Ed Willink on Feb 12, 2014 05:54

See ocl.examples.ui/plugin.xml

  <menuContribution locationURI="popup:org.eclipse.emf.ecore.presentation.ReflectiveEditorID?after=additions">\
     <menu id="org.eclipse.ocl.examples.ui.Menu" label="%MF_OCL">\
        <separator name="load" visible="true"/>\
        <separator name="save" visible="true"/>\
        <separator name="set" visible="true"/>\
        <separator name="show" visible="true"/>\
     </menu>\
  </menuContribution>

[eclipse-ocl-bot]

By marwa rostren on Feb 12, 2014 06:05

(In reply to Ed Willink from comment #5)

See ocl.examples.ui/plugin.xml

  <menuContribution

locationURI="popup:org.eclipse.emf.ecore.presentation. ReflectiveEditorID?after=additions">

  </menuContribution>

Okay I have used this

So to resume we will have to use this menuContribution and define the MF_OCL every time we create a custom model...

I think, users will not appreciate it ^_^, I will raise a bug.

[eclipse-ocl-bot]

By Ed Willink on Feb 12, 2014 06:21

Thanks.

You'll have more success if you contribute the fix, and make sure that both old and new names are present.

You can see from the equivalent any Xtext editor entry the benefits of a generic menu name.

[eclipse-ocl-bot]

By Ed Willink on Mar 09, 2014 12:08

(In reply to Ed Willink from comment #3)

Problem is that EMF generates a custom menu name.

Either raise a Bugzilla or add an entry to your custom model.

I'm reluctant to add an all-menus and a custom property tester everywhere.

This is causing problems for GMF editors too.

Instrumenting OCLPropertyTester shows that it is not executed very often, so this 'saving' seems trivial and the nuisance significant.

It also shows that OCLPropertyTester uses ACTIVE_EDITOR_NAME rather than ACTIVE_PART_NAME, so the current editor influences menu contributions elsewhere and vice-versa which may explain sluggish appearance of the OCL entries.

[eclipse-ocl-bot]

By Ed Willink on May 28, 2014 03:00

Menu available anywhere with a ResourceSet in M6.

[eclipse-ocl-bot]

By Ed Willink on May 25, 2015 17:21

CLOSED after more than a year in the RESOLVED state.