search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[editors] Use BackgroundOutlineTreeProvider #1419

Open eclipse-ocl-bot opened 2 hours ago

eclipse-ocl-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 453847 | | Status | NEW | | Importance | P3 normal | | Reported | Dec 02, 2014 02:49 EDT | | Modified | Apr 30, 2015 12:34 EDT | | Reporter | Ed Willink |

Description

As of Xtext 2.4 there is a BackgroundOutlineTreeProvider to avoid UI thread impact.

Use it.

It doesn't seem to be a plugin replacement for DefaultOutlineTreeProvider; no polymorphic dispatchers. Instead LabelProvider etc are re-used.

Since BackgroundOutlineTreeProvider is less than 100 lines of code, it may be better to just clone it and so preserve Xtext 2.3 compatibility.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Apr 18, 2015 15:24

(In reply to Ed Willink from comment #0)

Since BackgroundOutlineTreeProvider is less than 100 lines of code, it may be better to just clone it and so preserve Xtext 2.3 compatibility.

Beware BackgroundOutlineTreeProvider is enabled by instanceof tests

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Apr 30, 2015 12:34

Bug 465896#c3 reports an intermittent failure when starting a Complete OCL editor.

It appears that too many concurrent things may be happening. Eliminating the Outline from the startup main thread seems like a very good move that can only help.