search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

EnvironmentFactory is not properly configuring loading strategies #1469

Closed eclipse-ocl-bot closed 1 month ago

eclipse-ocl-bot commented 1 month ago

| --- | --- | | Bugzilla Link | 461615 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Mar 06, 2015 13:47 EDT | | Modified | Mar 07, 2015 05:06 EDT | | Reporter | Adolfo Sanchez-Barbudo Herrera |

Description

Problem is in AbstractEnvironmentFactory implementation which always configures a first load strategy even though when you want to configure a different one:

@Override\ public void configureLoadStrategy(@NonNull ProjectManager.IResourceLoadStrategy packageLoadStrategy, @Nullable ProjectManager.IConflictHandler conflictHandler) {\ ResourceSet externalResourceSet = getResourceSet();\ projectManager.configure(externalResourceSet, StandaloneProjectMap.LoadFirstStrategy.INSTANCE, StandaloneProjectMap.MapToFirstConflictHandler.INSTANCE);\ }

eclipse-ocl-bot commented 1 month ago

By Adolfo Sanchez-Barbudo Herrera on Mar 06, 2015 13:50

Please review asanchez/461615

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Mar 07, 2015 05:06

configureLoadStrategy/configureLoadFirstStrategy have almost no callers. Seems like a quick API to make a compilation problem go away.

Anyway your fix is obviously better.

Pushed to master for M6.

commit da6db6ab6fb1e85acbf89262cc08e132e2060fd7