search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[editors] /* Please wait */ after concurrent Compare edit #1555

Closed eclipse-ocl-bot closed 2 hours ago

eclipse-ocl-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 469967 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Jun 11, 2015 11:27 EDT | | Modified | Jun 26, 2015 11:39 EDT | | Reporter | Ed Willink |

Description

If a Complete OCL document is being edited, and the edited again via Compare With Head, a paste in the Compare Window causes the original edit to stick at / Please Wait /.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Jun 11, 2015 12:10

Also change branch while editor is open.

Clearly 'setInput()' is not triggering a new Worker Thread load.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Jun 12, 2015 07:14

(In reply to Ed Willink from comment #1)

Clearly 'setInput()' is not triggering a new Worker Thread load.

handleElementContentChanged is another entry point for change. It already creates the worker thread job; just fails to schedule it to run.

Relatively easy fix, BUT. For some reason a new IDocument is created and initially displayed but by the time the worker thread runs, the original IDocument is in use again. Fudged by a document2document MAP that redirects to the original. Ugh! horrible empirical code that I do not understand.

This solves the major problem of such at / Please Wait /, but undo can now traverse back via / Please Wait / and a blank screen to the original.

Maybe with a bit more study the Undo stack can be cleaned up.

The editor also goes dirty after a first change, so that a second change requires interaction with the discard edits pop-up.

A dilemma;

if the update is undoable, then it is indeed dirty.\ if the editor is not dirty then there can be nothing to undo

Anyway better functionality on ewillink/469967

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Jun 26, 2015 09:19

(In reply to Ed Willink from comment #2)

Anyway better functionality on ewillink/469967

commit 4ddf587d6d41307df7ef66e1da0f4300b0e1a3cc

pushed to master for M1.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Jun 26, 2015 11:39

commit 0cee98974719b8daabffe2246b390725e957b0b7

pushed to maintenance/R6_0 for SR1