eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

OCLinEcore editor removes conversionDelegates annotations #1646

Open eclipse-ocl-bot opened 1 month ago

eclipse-ocl-bot commented 1 month ago

| --- | --- | | Bugzilla Link | 482890 | | Status | NEW | | Importance | P3 normal | | Reported | Nov 24, 2015 06:05 EDT | | Modified | Nov 25, 2015 00:55 EDT | | Version | 6.0.0 | | Reporter | Denis Nikiforov |

Description

Created attachment 258240\ Test model

Hi

There is Common package in the attached model. The package has a conversionDelegates annotation. When I open the model in OCLinEcore editor and save it, the annotation disappears. I think it shouldn't.

sql.ecore

eclipse-ocl-bot commented 1 month ago

By Denis Nikiforov on Nov 24, 2015 06:11

I think the bug is related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=370087 but it's not a duplicate.

If it possible OCLinEcore must not remove existing annotations.

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Nov 24, 2015 06:49

The problem is that OCLinEcore has only partial support for EMF conversionDelegates. That is it recognises them and so removes them. The edit removes:

<eAnnotations source="http://www.eclipse.org/emf/2002/Ecore">\
  <details key="conversionDelegates" value="org.emftext.language.sql.conversionDelegateFactory"/>\
</eAnnotations>
eclipse-ocl-bot commented 1 month ago

By Ed Willink on Nov 24, 2015 06:57

The per-EClassifier EAnnotations are propagted ok.

It is the 'redundant' per-EPackage 'content' EAnnotation that gets lost.

Probably trivial to auto-generate the EPackage 'content' EAnnotation.

? is there a problem for queryDelegates too ?

?? what happens when EMF introdyces an XXXDelegate ?? shouldn't all unrecognised EAnnotations be propagated unchnaged?