Closed eclipse-ocl-bot closed 2 hours ago
By Ed Willink on Apr 20, 2016 05:26
Ripple: the *.qvtias loadability tests now fail with unresolved proxies.
It seems that lazy generation of xmi:ids for the generated Pivot model is bypassed by the standard proxy resolution. Easily fixed.
By Ed Willink on Apr 20, 2016 05:51
Pushed to master for M7.
| --- | --- | | Bugzilla Link | 492062 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Apr 20, 2016 03:58 EDT | | Modified | Apr 20, 2016 05:51 EDT | | Reporter | Ed Willink |
Description
The recent addition of ShadowExp part validation caused a failure in the QVTd JUnits tests where "Class" was used as the initialized shadow type in
/org.eclipse.qvtd.xtext.qvtcore.tests/src/org/eclipse/qvtd/xtext/qvtcore/tests/platformResource/org.eclipse.ocl.xtext.base/model/BaseCS2AS.qvtp.qvtc
The problem is that the 'wrong' Class' members are checked and since Class is a library / Metamodel mnerge the members of the Library Class are checked.
The constraint is indeed wrong since if Complete OCL adds a property, that propery needs initialization. The constraint must therefore do something like type.getCompleteClass().allProperties where getCompleteClass() is manually implemented so that the prevailing multi-model type system is used.
Therefore add a suite of getCompleteXXX operations (and related CompleteXXX navigations).
In the interim, changing CompleteClassImpl.getPrimaryClass to favour a return with a non-null esObject hides the problem.
Ripple: one JUnit test fails through comparing the 'wrong' Bag(Class) - fixed.
Ripple: three Junit tests fail through failing to convert the 'wrong' Boolean in Ecore AS2ES - AS2ES fixed.