eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[validation] Show additional details #1806

Open eclipse-ocl-bot opened 2 hours ago

eclipse-ocl-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 512430 | | Status | NEW | | Importance | P3 enhancement | | Reported | Feb 20, 2017 09:20 EDT | | Modified | Feb 21, 2017 09:15 EDT | | Reporter | Ed Willink |

Description

M5: The validation dialog resulting from using Validate on a profile diagram shows many errors, but neglects to show the details. A similar dialog in the Ecore/UML editir shows the same primary errors, but has a secondary text area where details of the selected error are shown.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Feb 20, 2017 10:50

M5: The validation dialog resulting from using Validate on a profile diagram

Correction, the problem occurs for OCL->Validate.

Secondary issue, why does Validation->Validate model show no problems.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Feb 20, 2017 12:21

(In reply to Ed Willink from comment #1)

Secondary issue, why does Validation->Validate model show no problems.

Possibly because, once Bug 512448 and Bug 512449 are fixed, EcoreOCLEValidator turns out to only parse check rather than validate OCL expressions. How has this bypassed testing?

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Feb 20, 2017 13:14

(In reply to Ed Willink from comment #2)

Possibly because, EcoreOCLEValidator turns out to only parse check rather than > validate OCL expressions.

No, but very similar oversight in UMLOCLValidator. Bug 512454.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Feb 21, 2017 08:49

(In reply to Ed Willink from comment #0)

A similar dialog in the Ecore/UML editir shows the same primary errors, but has a secondary text area where details of the selected error are shown.

No. The OCL ValidateCommand extends the EMF ValidateAction and has very similar functionality.

The better EMF dialog is in the Problems Tab that appears when model loading fails. See org.eclipse.emf.common.ui.editor.ProblemEditorPart.