search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[pivot-uml] Extension to base_Class is ambiguous. #1830

Open eclipse-ocl-bot opened 2 hours ago

eclipse-ocl-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 515050 | | Status | NEW | | Importance | P3 normal | | Reported | Apr 10, 2017 13:12 EDT | | Modified | May 17, 2017 14:11 EDT | | Depends on | 510503 | | Blocks | 515027 | | See also | 515038 | | Reporter | Ed Willink |

Description

Bug 515027 provides a repro in which an extension_Test ia ambiguous.

Bug 515038 fixes the silent treatment of this ambiguity.

The ambiguity should not actually occur.

It seems that when something uses Class as a metaclass the extension is available from both the meta- and super-class. ?? The meta-class provision is obsolete legacy ??

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Apr 10, 2017 14:26

(In reply to Ed Willink from comment #0)

?? The meta-class provision is obsolete legacy ??

Removing the metaclass property contributions has no effect on UMLValidateTests but breaks 4 out of 5 of the StereotypesTest.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on May 17, 2017 09:15

(In reply to Ed Willink from comment #1)

Removing the metaclass property

A fudge. The real issue is that a Stereotype applicable to a Class adds properties to THE Class and these are then inherited at a wrong meta-level.

See Bug 510503. We may need a different ResourceSet/type-system at each M-level.

We can perhaps work around it for Oxygen by putting in an EnvironmentView disambiguator that prefers more derived properties.

Without this disambiguator, the Bug 510538 fix might be breaking.

eclipse-ocl-bot commented 2 hours ago

By Leo Ufimtsev on May 17, 2017 11:01

(In reply to Ed Willink from comment #2)

Without this disambiguator, the Bug 510538 fix might be breaking.

Did you link to the correct bug? Seems like that low level SWT fix and this fix are somewhat disjoint.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on May 17, 2017 12:42

(In reply to Leo Ufimtsev from comment #3)

Without this disambiguator, the Bug 510538 fix might be breaking.

Did you link to the correct bug?

Correction Bug 515038.

An N-build should be available soon, but the Xtext nightly repo is obstinately broken. Maybe I'll have to bypass it.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on May 17, 2017 14:11

Adding a disambiguator that suppresses an ambiguity with a "base_Class" opposite satisfactorily fudges a solution, pending a proper Bug 510503 resolution.

commit 37b8e44407b2d0da2c40d1a16a1f3a6f9d4dda0a pushed to master for RC1

This bug remains open until Bug 510503 enables the fudge to be removed.