[uml] Prolific popups in Papyrus

[eclipse-ocl-bot]

| --- | --- | | Bugzilla Link | 521977 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Sep 07, 2017 04:08 EDT | | Modified | Sep 09, 2017 13:18 EDT | | See also | 521974, 467690 | | Reporter | Ed Willink |

Description

Bug 521974 has a bad UML file that results in many "Missing package for stereotype application of ..." errors each of which has to be dismissed individually by a Papyrus user. Really naff.

Problem is that error is reported by

logger.error("Missing package for stereotype application of " + umlStereotypeEClass.getName());

As well as irritating Papyrus users, this clogs the Error Log and so should also provoke AERI reports.

Perhaps it is time to eliminate all logger.error/warning in the normal code, instead aggregating the reports in some ProblemHandler and only reifying the multi-problem at the external API.

[eclipse-ocl-bot]

By Ed Willink on Sep 07, 2017 04:31

(In reply to Ed Willink from comment #0)

instead aggregating the reports in some ProblemHandler and only reifying the multi-problem at the external API.

The EMF way is to accumulate Resource.errors/warnings which competent calling code checks. Just need to make sure the ASResource.errors appear in the UMLResource.errors.

[eclipse-ocl-bot]

By Ed Willink on Sep 09, 2017 06:01

All UML2AS logger.error aggregates as a single Resource.errors entry with UMLOCLEValidator.ASResourceProblems routing to the validator diagnostics.

From Bug 467690 we must have a context object to comply with EValidator visibility policies. But what object for an aggregate, and do we want these OCL details to appear in UML?

[eclipse-ocl-bot]

By Ed Willink on Sep 09, 2017 13:18

Pushed to master for M2.