search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[tests] Resolve the commented out DebuggerTests #1949

Closed eclipse-ocl-bot closed 2 hours ago

eclipse-ocl-bot commented 2 hours ago

| --- | --- | | Bugzilla Link | 529886 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Jan 16, 2018 10:09 EDT | | Modified | Apr 03, 2018 14:29 EDT | | Blocks | 532591 | | See also | 529797, 526252, 532666 | | Reporter | Ed Willink |

Description

An inadvertent uncommenting of DebuggerTests added a major confusion to Bug 529797. Either activate or delete these tests. Perhaps the QVTi testing is adequate.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Mar 20, 2018 10:27

See https://www.eclipse.org/forums/index.php/mv/msg/1092367/1783933/#msg_1783933

The QVTi testing is clearly not adequate; the Getting started example fails.

(The "OCL Console Selection Error" - Failed to set 'self' is because org.eclipse.xtext.completeocl.utilities.CompleteOCLASResourceFactory.getASElement inherits an UnsupportedOperationException. Why wasn't this found by testing?)

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Mar 21, 2018 05:51

(In reply to Ed Willink from comment #1)

The QVTi testing is clearly not adequate;

It's commented out for Tycho. See Bug 526252.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Mar 22, 2018 06:26

(In reply to Ed Willink from comment #2)

The QVTi testing is clearly not adequate;

It's commented out for Tycho.

The launch does successfully create the right launch, but the doSave looks very smelly. Needs revamping for the TestFileSystem.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Mar 24, 2018 04:22

(In reply to Ed Willink from comment #3)

Needs revamping for the TestFileSystem.

Initially no difference, but once the missing debug.ui dependency added to ensure the debug launch delegate is registered, all QVTi Debugger tests working on Tycho.

Just need to make the OCLDebuggerTests work.

eclipse-ocl-bot commented 2 hours ago

By Ed Willink on Apr 03, 2018 14:29

(In reply to Ed Willink from comment #4)

Just need to make the OCLDebuggerTests work.

Relatively straightforward migration to use TestFileSystem and animate the full test which reveals Bug 533143.

But to avoid the inexplicable Bug 529797 failure on Tycho it is necessary to add a very brutal kill debug threads.

Pushed to master for M7.