[validation] Refresh Papyrus-emulation in LeakTests

| --- | --- | | Bugzilla Link | 530417 | | Status | NEW | | Importance | P3 normal | | Reported | Jan 28, 2018 09:48 EDT | | Modified | Jan 28, 2018 10:44 EDT | | See also | 521642, 530418 | | Reporter | Ed Willink |

Description

Bug 521642 revamps Diagnostician to use EcoreUtil.getAllContents rather than doValidateContents to traverse the containment hierarchy.

doValidateContents is therefore an obsolete API and of course any non-trivial override is likely to be broken.

In my workspace, I see

org.eclipse.xtext.validation.CancelableDiagnostician.doValidateContents

just ensures that isCanceled is polled regularly

org.eclipse.xtext.xbase.validation.XbaseDiagnostician.doValidateContents

a genuine/problematic variation for Lambdas

org.eclipse.ocl.examples.pivot.tests.MyDiagnostician.doValidateContents

this bug: comments suggest that it emulates the papyrus way of working:

protected boolean doValidateContents(EObject eObject, DiagnosticChain diagnostics, Map<Object, Object> context) {\
    boolean result = doValidateStereotypeApplications(eObject, diagnostics, context);\
    if (result || diagnostics != null) {\
        result &= super.doValidateContents(eObject, diagnostics, context);\
    }\
    return result;\
}

i.e. doValidateContents is adding the root elements that are probably omitted by a simple validation of aResource.getContents().get(0) or UMLUtil.load(...).

However a simple validate everything once should be ok.

Therefore update LeakTests to test whatever Papyrus moves to.

eclipse-ocl / org.eclipse.ocl

[validation] Refresh Papyrus-emulation in LeakTests #1956

Description