[validity] FillData CCE in ValidityView

[eclipse-ocl-bot]

| --- | --- | | Bugzilla Link | 542588 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Dec 10, 2018 04:04 EDT | | Modified | Feb 11, 2019 16:46 EDT | | Depends on | 536474 | | See also | Gerrit change https://git.eclipse.org/r/136723, Gerrit change https://git.eclipse.org/r/136728, Git commit bdc905c4 | | Reporter | Ed Willink |

Description

AERI reports https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/problems/5bc83de2e4b0ac09b977a074

A simple Open ValidityView with ValidityView.java as the current editor gives the trace below. (A 2016 saved version to see if line numbers chnage).

(Minor auxliary issue: the ErrorfLog report has no title.)

java.lang.ClassCastException: org.eclipse.swt.layout.GridData cannot be cast to org.eclipse.swt.layout.FillData\ at org.eclipse.swt.layout.FillLayout.flushCache(FillLayout.java:176)\ at org.eclipse.swt.widgets.Composite.layout(Composite.java:834)\ at org.eclipse.swt.widgets.Control.requestLayout(Control.java:2414)\ at org.eclipse.jface.action.ToolBarManager.relayout(ToolBarManager.java:224)\ at org.eclipse.jface.action.ToolBarManager.update(ToolBarManager.java:384)\ at org.eclipse.ocl.examples.emf.validation.validity.ui.view.ValidityView.fillLocalToolBar(ValidityView.java:672)\ at org.eclipse.ocl.examples.emf.validation.validity.ui.view.ValidityView.contributeToActionBars(ValidityView.java:344)\ at org.eclipse.ocl.examples.emf.validation.validity.ui.view.ValidityView.createValidityViewForm(ValidityView.java:543)\ at org.eclipse.ocl.examples.emf.validation.validity.ui.view.ValidityView.createPartControl(ValidityView.java:410)\ at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.createPartControl(CompatibilityPart.java:156)\ at org.eclipse.ui.internal.e4.compatibility.CompatibilityView.createPartControl(CompatibilityView.java:152)\ at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart.create(CompatibilityPart.java:367)\ at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\ at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\ at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\ at java.lang.reflect.Method.invoke(Method.java:498)\ at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:58)\ at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:1001)\ at org.eclipse.e4.core.internal.di.InjectorImpl.processAnnotated(InjectorImpl.java:966)\ at org.eclipse.e4.core.internal.di.InjectorImpl.internalInject(InjectorImpl.java:139)\ at org.eclipse.e4.core.internal.di.InjectorImpl.internalMake(InjectorImpl.java:411)\ at org.eclipse.e4.core.internal.di.InjectorImpl.make(InjectorImpl.java:333)\ at org.eclipse.e4.core.contexts.ContextInjectionFactory.make(ContextInjectionFactory.java:193)\ at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.createFromBundle(ReflectionContributionFactory.java:108)\ at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.doCreate(ReflectionContributionFactory.java:77)\ at org.eclipse.e4.ui.internal.workbench.ReflectionContributionFactory.create(ReflectionContributionFactory.java:59)\ at org.eclipse.e4.ui.workbench.renderers.swt.ContributedPartRenderer.createWidget(ContributedPartRenderer.java:132)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(PartRenderingEngine.java:1015)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:675)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$1.run(PartRenderingEngine.java:560)\ at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:544)\ at org.eclipse.e4.ui.workbench.renderers.swt.ElementReferenceRenderer.createWidget(ElementReferenceRenderer.java:73)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createWidget(PartRenderingEngine.java:1015)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:675)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.safeCreateGui(PartRenderingEngine.java:781)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.access$0(PartRenderingEngine.java:752)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$2.run(PartRenderingEngine.java:746)\ at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.createGui(PartRenderingEngine.java:730)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.subscribeTopicToBeRendered(PartRenderingEngine.java:160)\ at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\ at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\ at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\ at java.lang.reflect.Method.invoke(Method.java:498)\ at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:58)\ at org.eclipse.e4.core.di.internal.extensions.EventObjectSupplier$DIEventHandler.handleEvent(EventObjectSupplier.java:91)\ at org.eclipse.equinox.internal.event.EventHandlerWrapper.handleEvent(EventHandlerWrapper.java:205)\ at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:203)\ at org.eclipse.equinox.internal.event.EventHandlerTracker.dispatchEvent(EventHandlerTracker.java:1)\ at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:233)\ at org.eclipse.osgi.framework.eventmgr.ListenerQueue.dispatchEventSynchronous(ListenerQueue.java:151)\ at org.eclipse.equinox.internal.event.EventAdminImpl.dispatchEvent(EventAdminImpl.java:132)\ at org.eclipse.equinox.internal.event.EventAdminImpl.sendEvent(EventAdminImpl.java:75)\ at org.eclipse.equinox.internal.event.EventComponent.sendEvent(EventComponent.java:44)\ at org.eclipse.e4.ui.services.internal.events.EventBroker.send(EventBroker.java:55)\ at org.eclipse.e4.ui.internal.workbench.UIEventPublisher.notifyChanged(UIEventPublisher.java:63)\ at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:424)\ at org.eclipse.e4.ui.model.application.ui.impl.UIElementImpl.setToBeRendered(UIElementImpl.java:307)\ at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.showElementInWindow(ModelServiceImpl.java:636)\ at org.eclipse.e4.ui.internal.workbench.ModelServiceImpl.bringToTop(ModelServiceImpl.java:605)\ at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.delegateBringToTop(PartServiceImpl.java:791)\ at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:762)\ at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:684)\ at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:679)\ at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.showPart(PartServiceImpl.java:1231)\ at org.eclipse.ui.internal.WorkbenchPage.showPart(WorkbenchPage.java:1293)\ at org.eclipse.ui.internal.WorkbenchPage.busyShowView(WorkbenchPage.java:1282)\ at org.eclipse.ui.internal.WorkbenchPage.lambda$10(WorkbenchPage.java:4411)\ at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:72)\ at org.eclipse.ui.internal.WorkbenchPage.showView(WorkbenchPage.java:4409)\ at org.eclipse.ui.internal.WorkbenchPage.showView(WorkbenchPage.java:4389)\ at org.eclipse.ui.handlers.ShowViewHandler.openView(ShowViewHandler.java:135)\ at org.eclipse.ui.handlers.ShowViewHandler.openOther(ShowViewHandler.java:113)\ at org.eclipse.ui.handlers.ShowViewHandler.execute(ShowViewHandler.java:80)\ at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:294)\ at org.eclipse.ui.internal.handlers.E4HandlerProxy.execute(E4HandlerProxy.java:96)\ at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\ at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\ at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\ at java.lang.reflect.Method.invoke(Method.java:498)\ at org.eclipse.e4.core.internal.di.MethodRequestor.execute(MethodRequestor.java:58)\ at org.eclipse.e4.core.internal.di.InjectorImpl.invokeUsingClass(InjectorImpl.java:320)\ at org.eclipse.e4.core.internal.di.InjectorImpl.invoke(InjectorImpl.java:254)\ at org.eclipse.e4.core.contexts.ContextInjectionFactory.invoke(ContextInjectionFactory.java:164)\ at org.eclipse.e4.core.commands.internal.HandlerServiceHandler.execute(HandlerServiceHandler.java:156)\ at org.eclipse.core.commands.Command.executeWithChecks(Command.java:497)\ at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:490)\ at org.eclipse.e4.core.commands.internal.HandlerServiceImpl.executeHandler(HandlerServiceImpl.java:213)\ at org.eclipse.ui.internal.handlers.LegacyHandlerService.executeCommand(LegacyHandlerService.java:403)\ at org.eclipse.ui.internal.ShowViewMenu$1.run(ShowViewMenu.java:142)\ at org.eclipse.jface.action.Action.runWithEvent(Action.java:476)\ at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:568)\ at org.eclipse.jface.action.ActionContributionItem.lambda$4(ActionContributionItem.java:400)\ at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)\ at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4131)\ at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1055)\ at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3944)\ at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3547)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$5.run(PartRenderingEngine.java:1173)\ at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)\ at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1062)\ at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:156)\ at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:636)\ at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:339)\ at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:563)\ at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:151)\ at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:155)\ at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)\ at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:137)\ at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:107)\ at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:400)\ at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)\ at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\ at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\ at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\ at java.lang.reflect.Method.invoke(Method.java:498)\ at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)\ at org.eclipse.equinox.launcher.Main.basicRun(Main.java:595)\ at org.eclipse.equinox.launcher.Main.run(Main.java:1501)\ at org.eclipse.equinox.launcher.Main.main(Main.java:1474)

[eclipse-ocl-bot]

By Ed Willink on Dec 10, 2018 04:09

Bug 542584 has been marked as a duplicate of this bug.

[eclipse-ocl-bot]

By Ed Willink on Dec 10, 2018 07:15

Bug 542585 has been marked as a duplicate of this bug.

[eclipse-ocl-bot]

By Ed Willink on Dec 10, 2018 07:16

Bug 542586 has been marked as a duplicate of this bug.

[eclipse-ocl-bot]

By Ed Willink on Dec 10, 2018 07:16

Bug 542587 has been marked as a duplicate of this bug.

[eclipse-ocl-bot]

Feb 11, 2019 15:19

New Gerrit change created: https://git.eclipse.org/r/136723

[eclipse-ocl-bot]

By Ed Willink on Feb 11, 2019 15:27

As noted in Bug 536474 setting layouts on a SashForm is pointless. Setting layout data seems to be unnecesary but dangerous. Just lose the reduundant code.

[eclipse-ocl-bot]

Feb 11, 2019 16:27

New Gerrit change created: https://git.eclipse.org/r/136728

[eclipse-ocl-bot]

Feb 11, 2019 16:46

Gerrit change https://git.eclipse.org/r/136728 was merged to [master].\ Commit: http://git.eclipse.org/c/ocl/org.eclipse.ocl.git/commit/?id=bdc905c46b0a2121d788ffc44b9004892584ff7d

[eclipse-ocl-bot]

By Ed Willink on Feb 11, 2019 16:46

Pushed to master for M3.