search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[pivot] Use of XML entity during save introduces an incompatibility #2180

Closed eclipse-ocl-bot closed 1 month ago

eclipse-ocl-bot commented 1 month ago

| --- | --- | | Bugzilla Link | 573923 | | Status | RESOLVED FIXED | | Importance | P3 normal | | Reported | Jun 02, 2021 08:59 EDT | | Modified | Jun 05, 2021 15:16 EDT | | Blocks | 573916 | | See also | 562313 | | Reporter | Ed Willink |

Description

A standard EMF Ecore Resource save use the OPTION_SAVE_ONLY_IF_CHANGED_MEMORY_BUFFER to avoid rewriting unchanged files.

However the 'better' Pivot save now uses entities to compact URIs, which means that an OCLinEcore saved .ecore is 'changed' wrt a 'read-only' .ecore referevedd from a *.xmi. (The OCLinEcore toturial example underlying Bug 573916.

Presumably entity-based compression can only be used for .oclas / .qvtras where the OCL / QVTd custom Resource can impose consistent usage.

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Jun 03, 2021 08:55

Restricting the XMLResource.OPTION_RESOURCE_ENTITY_HANDLER usage of new IdResourceEntityHandler() to just ASResource (and ? redundantly AbstractASResourceFactory) should avoid the entity issue, but we need to ensure exact;y the same save options for .ecore (or .genmodel or *.uml) - no change of preferred line width.

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Jun 05, 2021 15:16

Done for 2021-06RC2.