eclipse-ocl-bot
commented
1 month ago By Ed Willink on Jan 30, 2022 09:54
(In reply to Ed Willink from comment #0)
Similarly AS2CG could create the CGTexts directly as CGLetExps
Easier to let the LocalContext accumulate the need-a-XXX-variable from AS2CG and/or CG2JavaPre and to synthesize the CGLetExp wrappers when the local context is popped in the CG2JavaPreVisitor.
using a much more disciplined CGJavaCall comprising regulare CGValueElement source and arguments; only the operation name need be a magic Java string
The CGNativeOperationCallExp can be repurposed with its method argument compil-checking the operatuin spellings.
CGParameter can introduce a name such as "this" and if an orphan avoid a reified paameter.
The LocalContext exexecutorVariable nicely polymorphises as a passed CGParameter or initialized CGVariable.
Just need to use CGValuedElement.setValueName to enforcce the exact spelling bypassing spurious collision avoidance.\
Once CGText has gone the owns can be eliminated and dependencies simplified..
CGText gone and certainly simplified, but owns is still used for shared global types etc.
| --- | --- | | Bugzilla Link | 578443 | | Status | NEW | | Importance | P3 normal | | Reported | Jan 29, 2022 09:25 EDT | | Modified | Nov 09, 2022 08:17 EDT | | Blocks | 534421 | | See also | Gerrit change 196695, Gerrit change 196696, Gerrit change 196698, Gerrit change 196699 | | Reporter | Ed Willink |
Description
CGText is a horrible bodge that was introduced to support too-hard-to-generate preformatted text infills. AS such it requires a variety of irregular treatments to support ownership, sharing, dependencies.
The foreign operation work for Bug 534421 struggles to correctly place the exeutor variable when the if initialization-needed is expressed in CG2Java. If instead AS2CG csynthesizes the true functionality CG2Java can be much simpler and subject to better optimization. Similarly AS2CG could create the CGTexts directlu as CgLetExps using a much more disciplined CGJavaCall comprising regulare CGValueElement source and arguments; only the operation name need be a magic Java string.
Once CGText has gone the owns can be eliminated and dependencies simplified..