search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[pivot] Rationalize ImmutabilityCheckingAdapter #2241

Open eclipse-ocl-bot opened 1 month ago

eclipse-ocl-bot commented 1 month ago

| --- | --- | | Bugzilla Link | 579109 | | Status | NEW | | Importance | P3 normal | | Reported | Mar 06, 2022 06:03 EDT | | Modified | Mar 18, 2022 07:49 EDT | | Blocks | 509309, 579051 | | See also | 551822, 579037 | | Reporter | Ed Willink |

Description

The ImmutabilityCheckingAdapter is/was a useful way of checking that shared ASResources were not being corruoted. However since the adapters are installed en masse by setSaveable without dynamic additions, the premature setSaveavle before addition of Resource contents meant that often the checking was missing.

Once the installation is improved, we need an isUpdating status while an ES2AS or CS2AS refreshes. And the notification changed filters need to handle too many properties that are not declared as transient.

e.g. the Element.ownedExtensions for UML should not mutate the remote end.

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Mar 06, 2022 13:38

Quite a bit of setSaveable / setUpdating tidying up needed.

Branch ready for 6.18 master.

Needs some API which makes it too hard / too late for 6.17.1RC2.

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Mar 18, 2022 07:49

After another round of fxing bad saving, the ImmutabilityCheckingAdapter is again redundant. It has successfully guided the introduction of the ASResource.setUpdating() API. Many of these usages should be eliminated once we have more coheremt transient property declarations.