eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[pivot] Rationalize MetamodelManager.getImplementation #2300

Open eclipse-ocl-bot opened 1 month ago

eclipse-ocl-bot commented 1 month ago

| --- | --- | | Bugzilla Link | 582354 | | Status | NEW | | Importance | P3 normal | | Reported | Aug 31, 2023 12:24 EDT | | Modified | Sep 09, 2023 15:41 EDT | | Reporter | Ed Willink |

Description

The getImplementation API is irregular wrt Iteration/Operation/Property usage.

The call is necessary to lazily complete loading but is bypassed irregularly.

The usage in PivotHelper.setOperationReturnType bypasses to avoid problems while parsing cyclic Complete OCL operation calls (see testValidate_IsPrimeNumber_completeocl). "PivotHelper" needs a clearer name for at least those parts that are only fro use during CS2AS.

Provide a cleaner clearer API.

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Sep 09, 2023 15:41

In a CS2AS conversion the implementationClass seems to be ignored in favour of an EInvokeOperation. It seems that the bias to prefer an OCL body got too strong.