search

eclipse-ocl / org.eclipse.ocl

Eclipse Public License 2.0
0 stars 0 forks source link

[tests] Use class-level NLS warning suppression. #470

Closed eclipse-ocl-bot closed 1 month ago

eclipse-ocl-bot commented 1 month ago

| --- | --- | | Bugzilla Link | 296291 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Nov 26, 2009 15:51 EDT | | Modified | May 27, 2011 02:47 EDT | | Version | 3.0.0 | | Reporter | Ed Willink |

Description

Some JUnit test classes have an NLS suppress warning on the class. Most have per-string comments.

When submitting some patches I switched policy making reviewing difficult. Before submitting changes to migrate tests to the share Ecore/UML infrastructure, I would like to change all JUnit test classes to have a single class level suppression of NLS warnings.

I trust that this can be approved in principle, bypassing a patch creation and review.

eclipse-ocl-bot commented 1 month ago

By Laurent Goubet on Nov 27, 2009 03:53

I aggree with commiting this as soon as the "fix" is ready. Class-level NLS suppression will remove some of the noise from the unit tests and doesn't sport any side effect that would require a review.

eclipse-ocl-bot commented 1 month ago

By Ed Willink on Nov 28, 2009 13:15

Committed to HEAD

eclipse-ocl-bot commented 1 month ago

By Ed Willink on May 27, 2011 02:47

Closing after over 18 months in resolved state.