[releng] Change features to use the Eclipse shared licenses

[eclipse-ocl-bot]

| --- | --- | | Bugzilla Link | 336491 | | Status | CLOSED FIXED | | Importance | P3 major | | Reported | Feb 07, 2011 06:28 EDT | | Modified | May 27, 2011 03:13 EDT | | Version | 3.1.0 | | Depends on | 336141 | | Reporter | Adolfo Sanchez-Barbudo Herrera |

Description

As soon as buckminster is able to create our feature's licenses using the new shared lincenses mechanism, we must change our features to make it use this new mechanism:

See: http://relengofthenerds.blogspot.com/2011/01/implementing-shared-licenses-with-37m5.html.

NB: Do we need to have an "empty" license file (which were overwritten), or no license file at all.

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Mar 30, 2011 05:19

In order to tackle this, we will have to move (and test) buckminster 3.7.

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Apr 18, 2011 08:59

The shared license mechanism has been adopted by our build process. For future license changes we will only have to do the following steps:

1. Change the license text in the org.eclipse.ocl.license-feature/feature.properties file
2. Increase the version of the license feature.
3. Search -> File on our features and search the following text: license-feature-version="1.0.0.qualifier" (note that 1.0.0 should change as long as the feature version increases)
4. Replace all the coincidences by the new licence-feature-version.

I've seized the opportunity to do some clean ups of our features. Specially, removing some unnecessary stuff which were probably used by previous/old build systems.

There is only one point which I've not faced on. There are some features which deal with the modeling32.png and some of them which don't deal with it:

• Some features include (export/build) the modeling32.png icon in the feature jar.
• Some features have the image="modeling32.png" attribute.

I've found a bugzilla related to this issue Bug 252014. As I conclude, neither we need to ship the modeling32.png icon nor we need to set the image property in the feature.xml. However, as commented in the bug, there may be a possibility in which somebody could be using said icon, so I've preferred to not change anything.

Due to the fact that this possibility is quite remote, I think that we could open a new bugzilla with the issue and definitely removing these unusued icons and properties from the features.

P.D: The following forum thread shows some faced issues concerning the buckminster 3.7 moving. Some annoying log will disappear with the next buckminster 3.7 milestone, there are some other which still need investigation (if they don't also disappear). I hope to spend some time in trying to fix this after M7.

[1] http://www.eclipse.org/forums/index.php?t=msg&goto=664992

[eclipse-ocl-bot]

By Ed Willink on Apr 18, 2011 13:03

Well done.

If someone wants modeling32.png they should get it from the primary modeling project: i.e. EMF not OCL.

Just lose it. I don't think we need a new Bugzilla.

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Apr 19, 2011 13:28

(In reply to comment #3)

Well done.

If someone wants modeling32.png they should get it from the primary modeling project: i.e. EMF not OCL.

Just lose it. I don't think we need a new Bugzilla.

Done. Tomorrow I'll do final some checks on the generated artifacts before resolving the bug.

Cheers,\ Adolfo.

[eclipse-ocl-bot]

By Adolfo Sanchez-Barbudo Herrera on Apr 20, 2011 13:34

All features look nice (no modeling32.png icon inside).

Resolving as fixed.

[eclipse-ocl-bot]

By Ed Willink on May 27, 2011 03:13

Closing