[ast] Regenerate Switch for SR1

[eclipse-ocl-bot]

| --- | --- | | Bugzilla Link | 352945 | | Status | CLOSED FIXED | | Importance | P3 normal | | Reported | Jul 24, 2011 07:45 EDT | | Modified | May 20, 2013 11:36 EDT | | Version | 3.1.0 | | Reporter | Ed Willink |

Description

Indigo EMF introduced an abstract Switch class for all switches. Not all Indigo models picked this up. Regenerate all models for SR1.

[eclipse-ocl-bot]

By Axel Uhl on Jul 24, 2011 12:07

The patch for 349117 already re-generated some models. Should we create a dependency between the bugs?

[eclipse-ocl-bot]

By Ed Willink on Aug 21, 2011 15:05

Created attachment 201877 Regeneration

The OCLCodeFormatter is now in the project preferences.

Organise importants and seemingly some slight formatting rule chnage gives many trivial changes.

Changes also pushed upstream as bug/352945.

:notepad_spiral: %5B352945%5D+Regenerate+from+genmodels+using+Indigo+EMF.patch

[eclipse-ocl-bot]

By Ed Willink on Aug 21, 2011 15:44

Created attachment 201880 SR1 patch eliminating text formatting changes

Patch for SR1, also pushed upstream as bug/352945sr1

:notepad_spiral: %5B352945%5D+Regenerate+from+genmodels+using+Indigo+EMF.patch

[eclipse-ocl-bot]

By Ed Willink on Aug 21, 2011 15:48

Please review attachment 201877 for M2.

Please review attachment 201880 for SR1.

[eclipse-ocl-bot]

By Axel Uhl on Aug 23, 2011 04:51

Reviewing. As far as I can see, all changes under org.eclipse.ocl.ecore.edit are really only whitespace changes and the project preferences which now contain the formatter. This part looks ok.

EcorePackage and EcoreAdapterFactory seem to have streamlined imports now which is good.

EcoreSwitch is where the significant changed based on the re-generation show up, particularly the new "extends Switch" which is the core reason for re-generating. The changes are all implied by the generator and look ok.

To org.eclipse.ocl.edit: again the formatter changes and accordingly all the many whitespace changes. I did some random reviews in some of the classes and they all appear to be whitespace-only changes (haven't found a good diff tool to suppress those; -w doesn't seem to do the job...). Same for org.eclipse.ocl.uml.edit.

In UMLAdapterFactory the imports are cleaned up. UMLSwitch has the above to-be-expected changes according to re-generation and a cleaned-up imports list. Ok. UMLValidator has the cleaned imports and whitespace-only changed. Also ok.

org.eclipse.ocl.cst.util.CSTSwitch has the expected changes with the new Switch base class factoring. The org.eclipse.ocl.expressions changes all look like whitespace-only.

ExpressionsSwitch: see above for the other Switch classes.

org.eclipse.ocl.types.impl only has whitespace changes.

TypesSwitch: see above for the other Switch classes.

UtilitiesAdapterFactory has cleaned-up imports. Ok.

UtilitiesSwitch: see above for the other Switch classes.

+1

[eclipse-ocl-bot]

By Ed Willink on Aug 23, 2011 13:12

Pushed to maintenance/R3_1 for SR1 RC2.

Pushed to master for M2.

[eclipse-ocl-bot]

By Ed Willink on May 20, 2013 11:36

CLOSED after a year in the RESOLVED state.