search

eclipse-oomph / oomph

Eclipse Public License 2.0
6 stars 11 forks source link

Manual tasks not executed after restart due to installation changes #70

Closed mmosconi1 closed 8 months ago

mmosconi1 commented 8 months ago

If I invoke "Perform Setup Tasks..." and the Manual Tasks to be executed require a restart (e.g. P2 changes), the remaining Manual Tasks are not executed after the restart.

merks commented 8 months ago

Now that you mention it, I think I ran into that today myself, but with all the multi-tasking I didn't pay so much attention. Maybe it's related to the new restart behavior of the Platform...

mmosconi1 commented 8 months ago

I just observed this with Eclipe 2022-06. Also had this earlier - don't know which versions.

merks commented 8 months ago

That's very old. So more likely something in Oomph itself then...

mmosconi1 commented 8 months ago

Btw - "Skip automatic task execution at startup time" in preferences is disabled. I guess, even if this is enabled, in case of a "Perform Setup Tasks..." manual invocation, it should be ignored if a restart is involved.

merks commented 8 months ago

I remote debugged this and it works for me. I use this simple way to reproduce the problem:

image

I.e., the modifying the eclipse.ini will require a restart and then the string substitution task should run on restart. And I can change the values so that both tasks are needed again.

With remote debug I can see that it's all working properly it should.

image

And yes, if there is a restart file the preference to skip startup tasks is ignored:

image

So I don't know how to proceed without being able to reproduce the problem.

Maybe there is something in the error log indicating some type of failure?

mmosconi1 commented 8 months ago

I can reproduce with the attached setup. It contains:

After initial installation, run "Perform Setup Tasks", go back in the wizard and change value of "foo" and proceed with all Manual Tasks selected. My results:

Note that the latter all get the following installed: Oomph Setup 1.31.0.v20240211-0940 Oomph Setup Launching 1.18.0.v20230617-1322

Nothing suspicious in the logs.

merks commented 8 months ago

I could reproduce this problem, but I get the sense it's reproducible because of how I am testing:

image

It's comparing the URIs of the things to be restarted against the URI of the task in the performer.

So I wonder if something like that is happening in your case too, i.e., some funky redirections or maybe even your own index.

In any case, I will try to add some logic that will hopefully generally fix such an issue.

merks commented 8 months ago

@mmosconi1

I committed a change that I think/hope will fix the problem generally. A build to produce a nightly update site is running

https://ci.eclipse.org/oomph/job/build/job/master/467/

This takes about an hour to complete (because mac notarization of the installers takes really long).

I must build the final 1.32 release today for contribution to SimRel 2024-03 later today...

Would you be able to test that this actually fixes the problem for you after the build is completed?

https://download.eclipse.org/oomph/updates/nightly/latest/

If there is still a problem, please locate this file and share the contents:

<workspace>/.metadata/.plugins/org.eclipse.oomph.setup.ui/restarting

Be sure that the installed bundle org.eclipse.oomph.setup.ui has today's timestamp for the version qualifier.

If you don't have time, what's there now will be what's in the final release.

merks commented 8 months ago

I've started the release build...

mmosconi1 commented 8 months ago

I'm a bit late, but - it works now! 👍 With local user setup (under Eclipse project catalog) as well as with our company-internal redirected index project catalog. Cool!

merks commented 8 months ago

That makes me feel good. Thanks for the confirmation.