eclipse-oomph / oomph

Eclipse Public License 2.0
6 stars 8 forks source link

OOmph uses outdated JDK path after JDK update #90

Open jukzi opened 1 month ago

jukzi commented 1 month ago

After JDK updates itself i always run into several error, because Eclipse Adoptium's path changes after update. So after eclipse stopped working (which is understandable) i tried to setup a fresh OOmmphed workspace. But it kept using the outdated path for "JRE 17 Location" I had to manually "Show all variables" and change the JDK location. image surprisingly Oomph seems to know that the old version does not exists anymore (was not selectable as JVM) but still auto-selected it by default :-( In such a case it would be nice if OOmph would automatically select a valid path only or actively asks about a valid location.

merks commented 1 month ago

I"m not sure how feasible that is. The previous choices are recorded in the user.setup (Navigate -> Open Setup -> User):

image

One cannot generally know that some task will not create the specified folder while performing...

merks commented 1 month ago

BTW, I assume you likely get other types of problems, i.e., that IDEs fail to start because the -vm option in the eclipse.ini points to a JRE that's been deleted. Is that the case too?

jukzi commented 1 month ago

bunch of other problems: yes. eclipse itself runs but jdt failed to compile stating for example java.lang.Object not found and many more

merks commented 1 month ago

This is why I never use the JDK installers because I really can't abide the potential have having ~100 installations become broken. Of course that's no consolation to those who do. Also, because folks don't generally read information that's presented to them, I'm not sure how to prompt a user to update the JRE location. E.g., isNeeded could return true when the JRE folder doesn't actually exist and then the task could fail with a message saying the JRE folder doesn't exist. But how to get the user to actual fix it, i.e., go to the variables page and show all variables and change the value. Or edit the user setup?