search

eclipse-openj9 / openj9-utils

Other
16 stars 29 forks source link

perf-tools: make timestamps nanosecond granular #32

Closed gireeshpunathil closed 3 years ago

gireeshpunathil commented 3 years ago

The current timestamp employed in the data has second's granularity, which can be too restrictive in many cases - for example in a high contention case, many sections may be seen as having the same timestamp. Convert time into nanosecond precision.

before: "timestamp": 1608336000 after: "timestamp": 1614073053488102314

Fixes: https://github.com/eclipse/openj9-utils/issues/19

Signed-off-by: Gireesh Punathil gpunathi@in.ibm.com

mpirvu commented 3 years ago

I searched up your email address in eclipse and you have signed ECA. I don't see anything wrong with the footer.

amicic commented 3 years ago

perhaps signoff needs to be the last line?

mpirvu commented 3 years ago

perhaps signoff needs to be the last line?

Perhaps, though the commit itself has the signoff on the last line.

0xdaryl commented 3 years ago

In most (if not all) other commits I've seen, the signer's email address is enclosed in angle brackets. Not sure if that is the issue here...

mpirvu commented 3 years ago

email address is enclosed in angle brackets.

I missed that. It seems that that was it.

gireeshpunathil commented 3 years ago

@mpirvu - fixed, added a short header to the commit message.

In most (if not all) other commits I've seen, the signer's email address is enclosed in angle brackets. Not sure if that is the issue here...

@0xdaryl - may be, but I followed the commit message in https://github.com/eclipse/openj9-utils/pull/18#issue-575768347 which passed the test, so that does not look to be the reason.

The commit message, though had an extra blank line, after the author field. May be that was not acceptable!