After working on a situation recently where the Xtrace count option proved useful, I realised that this option was not implemented in the Xtrace Option Builder. This commit addresses that omission.
Each tracepoint that's added to the tool will now have two new checkboxes - Trace, and Count:
This allows the user to choose whether they want to trace their chosen tracepoints, count the number of times they are hit, or both. The default is trace only, which matches the previous behaviour.
The patch is perhaps larger than expected due to the changes required for enabling/disabling elements appropriately, error checking updates, and updates to the link creation and parameter parsing code.
I also fixed some very minor layout issues that I encountered along the way.
pshipton
commented
1 year ago
After working on a situation recently where the Xtrace
countoption proved useful, I realised that this option was not implemented in the Xtrace Option Builder. This commit addresses that omission.More information on the
countoption:https://www.eclipse.org/openj9/docs/xtrace/#count-tracepoint
Each tracepoint that's added to the tool will now have two new checkboxes - Trace, and Count:
This allows the user to choose whether they want to trace their chosen tracepoints, count the number of times they are hit, or both. The default is trace only, which matches the previous behaviour.
The patch is perhaps larger than expected due to the changes required for enabling/disabling elements appropriately, error checking updates, and updates to the link creation and parameter parsing code.
I also fixed some very minor layout issues that I encountered along the way.
Signed-off-by: Paul Cheeseman paul.cheeseman@uk.ibm.com