Ensure AOT compilation in jitdump

eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.

Other

3.28k stars 721 forks source link

Ensure AOT compilation in jitdump #10962

Open dsouzai opened 4 years ago

dsouzai commented 4 years ago

If a crash happens in an AOT body, the jitdump should generate an AOT compilation. However, this is not as trivial as it might seem, as there are three scenarios:

[x] 1. Crash during an AOT compile - https://github.com/eclipse/openj9/pull/10852
[ ] 2. Crash in an AOT body that was generated in the current JVM instance
[ ] 3. Crash in an AOT body that was generated in a different JVM instance

Regarding 2, should the jitdump redo the AOT compilation, the AOT load, or both? Regarding 3, should the jitdump redo the AOT load?

dsouzai commented 4 years ago

fyi @mpirvu @fjeremic

mpirvu commented 4 years ago

I wonder about the value of [3] since typically we want to get to compilation logs. Moreover, the advantage of jitdump is that it can generate a log from the the same JDK that produced the bad jitted body. If the AOT body has been produced in a previous run, we lose that advantage, so a compilation log from a brand new JVM invocation may be just as good.

Regarding 2, should the jitdump redo the AOT compilation, the AOT load, or both?

I think we want to redo the AOT compilation.

dsouzai commented 4 years ago

^T'was by accident