search

eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.27k stars 721 forks source link

Re-enable excluded mh tests #12853

Open tajila opened 3 years ago

tajila commented 3 years ago

See https://github.com/eclipse-openj9/openj9/pull/12779 for a list of excluded tests

com.ibm.j9.jsr292.MethodHandleTest:testBindTo AN-https://github.com/eclipse-openj9/openj9/issues/12571 generic-all
    com.ibm.j9.jsr292.AsTypeTest:testAll AN-https://github.com/eclipse-openj9/openj9/issues/12571 generic-all
    com.ibm.j9.jsr292.PermuteTest:testPermuteArguments AN-https://github.com/eclipse-openj9/openj9/issues/12571 generic-all
    com.ibm.j9.jsr292.VirtualHandleTest:testIfVirtualHandleTestIsJitted AN-https://github.com/eclipse-openj9/openj9/issues/12571 generic-all
    com.ibm.j9.jsr292.ConstructorHandleTest:testIfConstructorHandleIsJitted AN-https://github.com/eclipse-openj9/openj9/issues/12571 generic-all
    com.ibm.j9.jsr292.ReceiverBoundHandleTest:testIfRecieverBoundHandleTestIsJitted AN-https://github.com/eclipse-openj9/openj9/issues/12571 generic-all
    com.ibm.j9.jsr292.InterfaceHandleTest:testIfInterfaceHandleIsJitted AN-https://github.com/eclipse-openj9/openj9/issues/12571 generic-all
fengxue-IS commented 3 years ago

As per discussion in #12571, testBindTo has been fixed and re-enabled testAll & testPermuteArguments matches RI behavior so we should look into possibly updating the testcase *HandleIsJitted tests doesn't apply for OJDK MH, and should either be excluded or updated to match new design

as none of the above issue have any functional issue, I suggest we move this out of 0.28 milestone. @JasonFengJ9 FYI

JasonFengJ9 commented 3 years ago

testAll & testPermuteArguments matches RI behavior so we should look into possibly updating the testcase *HandleIsJitted tests doesn't apply for OJDK MH, and should either be excluded or updated to match new design

Agreed that these tests don't apply to OJDK MH enabled JDK16+, should be updated or excluded, ideally for JDK16+ only before OJDK MH enabled for earlier Java levels. Moving to 0.29 release target.

Note: these tests are within functional/Jsr292/src/com/ibm/j9/jsr292 which intended to verify JSR292 functionalities.

tajila commented 2 years ago

@babsingh Can you ensure that we have enabled all fixed tests

babsingh commented 2 years ago

@babsingh Can you ensure that we have enabled all fixed tests

Yes, we have enabled all tests, which check for the correct behaviour.

For the remaining excluded tests in feature_ojdkmh_exclude.txt, OpenJ9 w/ OJDK MHs matches RI. *HandleTestIsJitted tests verify OJ9 MH specific behaviour. Depending upon the test's relevance, we can either update the test to check for the correct behaviour or remove the test.

Summary of excluded tests:

Correcting the above tests is not a priority for the 0.29.1 release. So, this PR can be targeted for the next release.

fyi @tajila