Open tajila opened 2 years ago
This is blocking https://github.com/eclipse-openj9/openj9/issues/13547
In the middle of #13414, may take me some time to get to this.
Okay, @EricYangIBM can you take a look at this
Long term we will need to make a new repo https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes which will be based off https://github.com/openjdk/valhalla
Is this openj9-openjdk-jdk.valuetypes
going to be the repo github.com/openjdk/valhalla
w/ OpenJ9 JCL patches just like openj9-openjdk-jdk
which is github.com/openjdk/jdk
w/ JCL patches?
It sounds another extension repo mirror/merging build from github.com/openjdk/valhalla
regularly before valhalla
is merged into jdk
head stream, right?
It sounds another extension repo mirror/merging build from github.com/openjdk/valhalla regularly before valhalla is merged into jdk head stream, right?
Yes, thats the idea. The closer we get to the release the more JCL changes we will need for VTs
We will also need to do something like this for Loom
Yes, thats the idea. The closer we get to the release the more JCL changes we will need for VTs We will also need to do something like this for Loom
Sure, do we have some timelines set for these repos?
Sooner the better. It will require some work from releng side so I imagine we can get to this after the next couple releases.
Sooner the better. It will require some work from releng side so I imagine we can get to this after the next couple releases.
Tracking this at infrastructure/issues/6004
.
The existing valuetypes JDK is based off of jdknext. This repo doesn't have the required VT support in method handles. We will need to start building off https://github.com/openjdk/valhalla instead of the head repo.
In the short term, we will need to change our tests to use
makeValueGeneric
helpers andgenerate[Getter|Setter|Wither]Generic
helpers as they do not mention q-types. Anything that mentions q-types right now will not work with ojdk_mh.Long term we will need to make a new repo
https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes
which will be based off https://github.com/openjdk/valhalla