search

eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.26k stars 717 forks source link

ValueTypes: Add support for ojdk_mh #13549

Open tajila opened 2 years ago

tajila commented 2 years ago

The existing valuetypes JDK is based off of jdknext. This repo doesn't have the required VT support in method handles. We will need to start building off https://github.com/openjdk/valhalla instead of the head repo.

In the short term, we will need to change our tests to use makeValueGeneric helpers and generate[Getter|Setter|Wither]Generic helpers as they do not mention q-types. Anything that mentions q-types right now will not work with ojdk_mh.

Long term we will need to make a new repo https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes which will be based off https://github.com/openjdk/valhalla

tajila commented 2 years ago

This is blocking https://github.com/eclipse-openj9/openj9/issues/13547

hangshao0 commented 2 years ago

In the middle of #13414, may take me some time to get to this.

tajila commented 2 years ago

Okay, @EricYangIBM can you take a look at this

JasonFengJ9 commented 2 years ago

Long term we will need to make a new repo https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes which will be based off https://github.com/openjdk/valhalla

Is this openj9-openjdk-jdk.valuetypes going to be the repo github.com/openjdk/valhalla w/ OpenJ9 JCL patches just like openj9-openjdk-jdk which is github.com/openjdk/jdk w/ JCL patches? It sounds another extension repo mirror/merging build from github.com/openjdk/valhalla regularly before valhalla is merged into jdk head stream, right?

tajila commented 2 years ago

It sounds another extension repo mirror/merging build from github.com/openjdk/valhalla regularly before valhalla is merged into jdk head stream, right?

Yes, thats the idea. The closer we get to the release the more JCL changes we will need for VTs

tajila commented 2 years ago

We will also need to do something like this for Loom

JasonFengJ9 commented 2 years ago

Yes, thats the idea. The closer we get to the release the more JCL changes we will need for VTs We will also need to do something like this for Loom

Sure, do we have some timelines set for these repos?

tajila commented 2 years ago

Sooner the better. It will require some work from releng side so I imagine we can get to this after the next couple releases.

JasonFengJ9 commented 2 years ago

Sooner the better. It will require some work from releng side so I imagine we can get to this after the next couple releases.

Tracking this at infrastructure/issues/6004.