Closed dylanjtuttle closed 1 year ago
Irwin @dsouzai, may I ask you to look at this? I think it might have something to do with changes for pull request #17621. One commit moved the following flags to TR_RelocationFlags
inlinedMethodIsStatic = 0x01,
inlinedMethodIsSpecial = 0x02,
which overlap the definitions of the following flags in OMR's compiler/runtime/Runtime.hpp
RELOCATION_TYPE_EIP_OFFSET = 0x1,
RELOCATION_TYPE_WIDE_OFFSET = 0x2,
ITERATED_RELOCATION_TYPE_ORDERED_PAIR = 0x4,
// ITERATED_RELOCATION_TYPE_ORDERED_PAIR is not stored in the binary template
// as the isOrderedPairRelocation API is used to determine whether a given
// relocation is an Orderd Pair Relocation or not.
RELOCATION_CROSS_PLATFORM_FLAGS_MASK = (RELOCATION_TYPE_EIP_OFFSET | RELOCATION_TYPE_WIDE_OFFSET),
Ah, it's because these asserts are actually incorrect after https://github.com/eclipse-openj9/openj9/pull/17621. What they should do is what you see in https://github.com/eclipse-openj9/openj9/blob/e8d07cf4374c9eb4cc369bfc45740f5bacdf54ac/runtime/compiler/runtime/RelocationRecord.cpp#L951-L955
Given that there's an actual fatal assert when we call setReloFlags
, we don't need any of those TR_ASSERT
s anymore. I'll clean it up.
The assertion at
/home/jenkins/workspace/Build_JDK11_x86-64_linux_Personal/openj9/runtime/compiler/codegen/J9AheadOfTimeCompile.cpp:552: (flags & RELOCATION_CROSS_PLATFORM_FLAGS_MASK) == 0
fails during
sanity.functional
set up (prior to start of build) when runningjava -version
onx86_64-linux
for Java 11.Link to the Jenkins job.
Stack trace: