eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.28k stars 721 forks source link

Build-test pipeline doesn't support custom aqa-test repo #19231

Open fengxue-IS opened 6 months ago

fengxue-IS commented 6 months ago

Launching a build via the jenkins pipeline doesn't allow passing in a custom aqa-test repo/branch. This makes testing against excluded test needing a lot of extra work in order to ensure test coverage without generating regressions.

FYI @llxia

llxia commented 6 months ago

Talked with @gita-omr , we should also support custom EXTRA_OPTIONS

llxia commented 6 months ago

We will allow users to set ADOPTOPENJDK_REPO, ADOPTOPENJDK_BRANCH, USE_TESTENV_PROPERTIES and EXTRA_OPTIONS in Pipeline-Build-Test-Personal job.

When USE_TESTENV_PROPERTIES is set to true, testenv.properties file in ADOPTOPENJDK_REPO and ADOPTOPENJDK_BRANCH will be used. (i.e., https://github.com/adoptium/aqa-tests/blob/master/testenv/testenv.properties). testenv.properties can be used to set other repos and branches (i.e., for openjdk jdk11 repo, set JDK11_OPENJ9_REPO)

llxia commented 6 months ago

Pipeline-Build-Test-Personal job config is updated to include the above test pipeline parameters.

keithc-ca commented 6 months ago

Re-opening: https://github.com/eclipse-openj9/openj9/pull/19281 was reverted by https://github.com/eclipse-openj9/openj9/pull/19317.