Open pshipton opened 1 month ago
getDependencies section looks the same.
00:00:30.452 downloading https://openj9-jenkins.osuosl.org//job/systemtest.getDependency/lastSuccessfulBuild/artifact/systemtest_prereqs/log4j/log4j-core.jar
00:00:30.709 --> file downloaded to /home/jenkins/workspace/Grinder/../../testDependency/system_lib/log4j/log4j-core.jar
00:00:30.709 Checksum verification skipped for /home/jenkins/workspace/Grinder/../../testDependency/system_lib/log4j/log4j-core.jar
...
00:01:03.887 downloading https://openj9-jenkins.osuosl.org//job/systemtest.getDependency/lastSuccessfulBuild/artifact/systemtest_prereqs/log4j/log4j-api.jar
00:01:04.359 --> file downloaded to /home/jenkins/workspace/Grinder/../../testDependency/system_lib/log4j/log4j-api.jar
00:01:04.359 Checksum verification skipped for /home/jenkins/workspace/Grinder/../../testDependency/system_lib/log4j/log4j-api.jar
...
00:00:33.510 downloading https://openj9-jenkins.osuosl.org//job/systemtest.getDependency/lastSuccessfulBuild/artifact/systemtest_prereqs/junit/junit.jar
00:00:33.510 --> file downloaded to /home/jenkins/workspace/Grinder/../../testDependency/system_lib/junit/junit.jar
00:00:33.510 Checksum verification skipped for /home/jenkins/workspace/Grinder/../../testDependency/system_lib/junit/junit.jar
00:04:09.878 GEN /home/jenkins/testDependency/system_lib/log4j/log4j-api.jar
00:04:09.878 GEN /home/jenkins/testDependency/system_lib/log4j/log4j-core.jar
00:04:09.878 GEN /home/jenkins/testDependency/system_lib/junit/junit.jar
...
Tested with 3 old SHA: ADOPTOPENJDK_BRANCH: 42609ec5c70, STF: f8d647e99075 and TKG: 3ed8f8b66bc https://openj9-jenkins.osuosl.org/job/Grinder/3642/ passed onub20-aarch64-osu-1: https://openj9-jenkins.osuosl.org/job/Grinder/3642/
Failed run:
00:04:52.634 GEN /home/jenkins/testDependency/system_lib/sharedClassesTestData/v1 exists
...
00:04:52.897 STF 21:02:26.302 - +------ Step 1 - Copy sharedClasses jar
00:04:52.897 STF 21:02:26.302 - | Copy a file to another directory
00:04:52.897 STF 21:02:26.302 - | Source file: /home/jenkins/testDependency/system_lib/sharedClassesTestData/v1/classes.jar
00:04:52.897 STF 21:02:26.302 - | Dest dir: /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_17171029401691/SharedClasses.SCM01.SingleCL_0/20240530-210221-SharedClasses/tmp
00:04:52.897 STF 21:02:26.302 - |
...
Passed run:
00:05:45.246 GEN /home/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/sharedClassesTestData/v1 does not exist
...
00:05:45.505 STF 23:43:13.044 - +------ Step 1 - Create Shared Classes jars
...
00:05:45.505 STF 23:43:13.044 - Running command: /home/jenkins/workspace/Grinder/jdkbinary/j2sdk-image/bin/java -classpath /home/jenkins/workspace/Grinder/jvmtest/system/STF/stf.core/bin:/home/jenkins/workspace/Grinder/jvmtest/system/openj9-systemtest/openj9.test.sharedClasses/bin net.openj9.test.sc.JavaGen /home/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/sharedClassesTestData/v1 10000
00:05:45.505 STF 23:43:13.044 - Redirecting stderr to /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_17171125877172/SharedClasses.SCM01.SingleCL_0/20240530-234308-SharedClasses/results/1.CSC.stderr
00:05:45.505 STF 23:43:13.044 - Redirecting stdout to /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_17171125877172/SharedClasses.SCM01.SingleCL_0/20240530-234308-SharedClasses/results/1.CSC.stdout
00:05:45.505 STF 23:43:13.056 - Monitoring processes: CSC
00:05:46.074 CSC 30/05/24 23:43:13: Generating jar files in /home/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/sharedClassesTestData/v1
...
It looks like the test is leveraging system_lib
dir to store sharedClasses jar. It was not a problem because system_lib
(previously called systemtest_prereqs
) was created under workspace (get deleted after each run). The problem shows up when system_lib
is preserved.
Fix: we need to redirect SharedClasses tests to generate related classes under workspace dir, not system_lib
.
https://github.com/eclipse-aqavit/openj9-systemtest/blob/0cc1cdb8e33b41de4478f8f07d53a461905e5f49/openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/stf/SharedClasses.java#L193
Try getTestRoots(), getTmpDir(), or getResultsDir(). (see https://github.com/adoptium/STF/blob/f40f3ca179d2bcd7f6c32838d5475c5f0a26cb47/stf.core/src/stf.core/net/adoptopenjdk/stf/environment/StfEnvironmentCore.java)
@annaibm please take care of this. We need to ensure that getPrereqRoots()
is not used anywhere other than getting 3rd party jars. Thanks
Also SharedClasses.SCM23.SingleCL, SharedClasses.SCM01.MultiCL, SharedClasses.SCM23.MultiCL, SharedClasses.SCM01.MultiThreadMultiCL.
https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-JDK22-with-System/79/ https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-JDK17/761/ https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-JDK11/818/ https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-JDK8/841/
https://openj9-jenkins.osuosl.org/job/Test_openjdk8_j9_extended.system_aarch64_linux_Nightly_testList_1/684/
61.0 is jdk17.
https://openj9-jenkins.osuosl.org/job/Test_openjdk22_j9_extended.system_aarch64_linux_Nightly_testList_0/78
67.0 is jdk23
Changes from the previous working build https://github.com/eclipse-openj9/openj9/compare/7c623220d1...b9fd76df770 https://github.com/adoptium/aqa-tests/compare/42609ec5c70...a4ef8f2aff2860 https://github.com/adoptium/TKG/compare/3ed8f8b66bc...b9e1d278d2e https://github.com/adoptium/STF/compare/f8d647e99075...f40f3ca179d2