eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.23k stars 712 forks source link

[zOS S390] 80 JVM_Functionality.RAS Trace Non-Smoke.Mode110.1 ArrayIndexOutOfBoundsException: Array index out of range: 0 at com.ibm.trace.tests.apptrace.TestJavaCoreAndSnap.main(TestJavaCoreAndSnap.java:36) & Trace point lines did not match:j9mm.668 vs base #19703

Closed JasonFengJ9 closed 2 weeks ago

JasonFengJ9 commented 3 weeks ago

Failure link

From an internal build(inec015):

java version "1.8.0_421"
Java(TM) SE Runtime Environment (build 8.0.9.0 - pmz3180sr9-20240606_01(SR9))
IBM J9 VM (build 2.9, JRE 1.8.0 z/OS s390-31-Bit 20240611_72686 (JIT enabled, AOT enabled)
OpenJ9   - 72d7b22cf43
OMR      - 0b69ee8
IBM      - 8eac2b8)
JCL - 20240513_01 based on Oracle jdk8u421-b05

Optional info

Failure output (captured from console output)

trace_history.pl>> 2024 Tue Jun 11 19:18:26 TestJavaCoreAndSnap: started
trace_history.pl>> 2024 Tue Jun 11 19:18:26 Comparing current thread trace in javacore.txt and snap.trc.fmt
trace_history.pl>> 2024 Tue Jun 11 19:18:26 Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Array index out of range: 0
trace_history.pl>> 2024 Tue Jun 11 19:18:26     at com.ibm.trace.tests.apptrace.TestJavaCoreAndSnap.main(TestJavaCoreAndSnap.java:36)
trace_history.pl>> 2024 Tue Jun 11 19:18:26 
---
trace_history.pl>> 2024 Tue Jun 11 19:18:26 Finished main__runCompareJavaCoreHistoryAndSnap

100x internal grinder - 20/100 failed Others failures

trace_history.pl>> 2024 Thu Jun 13 12:07:06 Running main__runCompareJavaCoreHistoryAndSnap
trace_history.pl>> 2024 Thu Jun 13 12:07:06 Launching java -cp "/j9vm/ebcdic/builds/bld_72686/jvmtest/VM/rastest/trace/trace_history/../../../com.ibm.jvm.ras.tests/com.ibm.jvm.ras.tests.jar" -Xnocompressedrefs com.ibm.trace.tests.apptrace.TestJavaCoreAndSnap javacore.txt snap.trc.fmt
trace_history.pl>> 2024 Thu Jun 13 12:07:11 Command finished
trace_history.pl>> 2024 Thu Jun 13 12:07:11 Command failed, contents of main__runCompareJavaCoreHistoryAndSnap.txt:
---

trace_history.pl>> 2024 Thu Jun 13 12:07:11 JVMJ9VM082E Unable to switch to IFA processor - issue "extattr +a libj9ifa29.so"
trace_history.pl>> 2024 Thu Jun 13 12:07:11 TestJavaCoreAndSnap: started
trace_history.pl>> 2024 Thu Jun 13 12:07:11 Comparing current thread trace in javacore.txt and snap.trc.fmt
trace_history.pl>> 2024 Thu Jun 13 12:07:11 Trace point lines did not match:j9mm.668 vs base
trace_history.pl>> 2024 Thu Jun 13 12:07:11 Javacore: 19:06:56:768480762 GMT j9mm.668 -  >MSSSS::allocate type Object size 40360 subspace this 197146201bfef1d4/
trace_history.pl>> 2024 Thu Jun 13 12:07:11 Snap trace: ,x??p?  base 0x1971462000000000 prev 0x0 shouldCollectOnFailure 426740000
trace_history.pl>> 2024 Thu Jun 13 12:07:11 TestJavaCoreAndSnap: failed
trace_history.pl>> 2024 Thu Jun 13 12:07:11 TestJavaCoreAndSnap: finished
trace_history.pl>> 2024 Thu Jun 13 12:07:11 
---
trace_history.pl>> 2024 Thu Jun 13 12:07:11 Finished main__runCompareJavaCoreHistoryAndSnap

A similar failure [Windows IA32] 80 JVM_Functionality.RAS Trace Non-Smoke.Mode110.1

trace_history.pl>> 2024 Tue Jun 11 22:25:39 Running main__runCompareJavaCoreHistoryAndSnap
trace_history.pl>> 2024 Tue Jun 11 22:25:39 Launching java -cp "W:\builds\bld_72686\jvmtest\VM\rastest\trace\trace_history\..\..\..\com.ibm.jvm.ras.tests\com.ibm.jvm.ras.tests.jar" -Xnocompressedrefs com.ibm.trace.tests.apptrace.TestJavaCoreAndSnap javacore.txt snap.trc.fmt
trace_history.pl>> 2024 Tue Jun 11 22:25:44 Command finished
trace_history.pl>> 2024 Tue Jun 11 22:25:44 Command failed, contents of main__runCompareJavaCoreHistoryAndSnap.txt:
---

trace_history.pl>> 2024 Tue Jun 11 22:25:44 TestJavaCoreAndSnap: started
trace_history.pl>> 2024 Tue Jun 11 22:25:44 Comparing current thread trace in javacore.txt and snap.trc.fmt
trace_history.pl>> 2024 Tue Jun 11 22:25:44 Trace point lines did not match:j9vm.47 vs j9vm.683
trace_history.pl>> 2024 Tue Jun 11 22:25:44 Javacore: 02:25:30:010051019 GMT j9vm.47 -   hook registration (register/unregister=1 event=6 function=745DC4A0 userData=00000000)
trace_history.pl>> 2024 Tue Jun 11 22:25:44 Snap trace: 02:25:30.019129824  0x01337200 j9vm.683            Exit       <WalkStackFrames - walkThread=0x1337200, rc=0
trace_history.pl>> 2024 Tue Jun 11 22:25:44 TestJavaCoreAndSnap: failed
trace_history.pl>> 2024 Tue Jun 11 22:25:44 TestJavaCoreAndSnap: finished
trace_history.pl>> 2024 Tue Jun 11 22:25:44 
---
trace_history.pl>> 2024 Tue Jun 11 22:25:44 Finished main__runCompareJavaCoreHistoryAndSnap
pshipton commented 3 weeks ago

This doesn't seem a new failure, it's probably been happening for quite some time, perhaps forever, but the history doesn't go back that far. @keithc-ca fyi, if you want to investigate..

pshipton commented 2 weeks ago

The fix for ArrayIndexOutOfBoundsException may expose the next problem.

trace_history.pl>> 2024 Mon Jun 17 08:05:25 Comparing current thread trace in javacore.txt and snap.trc.fmt
trace_history.pl>> 2024 Mon Jun 17 08:05:25 Trace point lines did not match:j9mm.668 vs base
trace_history.pl>> 2024 Mon Jun 17 08:05:25 Javacore: 15:05:11:096712379 GMT j9mm.668 -  >MSSSS::allocate type Object size 40360 subspace this 197146201bfef1d4/
trace_history.pl>> 2024 Mon Jun 17 08:05:25 Snap trace: ,x??p?  base 0x1971462000000000 prev 0x0 shouldCollectOnFailure 426740000
trace_history.pl>> 2024 Mon Jun 17 08:05:25 TestJavaCoreAndSnap: failed
pshipton commented 2 weeks ago

The test is looking for 3XEHSTTYPE which seems to not always exist in the javacore. In a ArrayIndexOutOfBoundsException failing example, the javacore contains only the header

1XECTHTYPE     Current thread history (J9VMThread:0x3D236100)
1XMCURTHDINFO  Current thread
3XMTHREADINFO      "main" J9VMThread:0x3D236100, omrthread_t:0x19C6E310, java/lang/Thread:0x3C722870, state:R, prio=5
3XMJAVALTHREAD            (java/lang/Thread getId:0x1, isDaemon:false)
3XMJAVALTHRCCL            sun/misc/Launcher$AppClassLoader(0x3C701588)
3XMTHREADINFO1            (native thread ID:0x2, native priority:0x5, native policy:UNKNOWN, vmstate:R, vm thread flags:0x00041020)
3XMCPUTIME               CPU usage total: 0.165000000 secs, current category="Application"
3XMHEAPALLOC             Heap bytes allocated since last GC cycle=380096 (0x5CCC0)
3XMTHREADINFO3           Java callstack:
4XESTACKTRACE                at com/ibm/jvm/Dump.JavaDumpImpl(Native Method)
4XESTACKTRACE                at com/ibm/jvm/Dump.JavaDump(Dump.java:123)
4XESTACKTRACE                at com/ibm/trace/tests/apptrace/GenerateJavaCoreAndSnap.main(GenerateJavaCoreAndSnap.java:14)
3XMTHREADINFO3           No native callstack available on this platform
JasonFengJ9 commented 2 weeks ago

trace_history.pl>> 2024 Mon Jun 17 08:05:25 Trace point lines did not match:j9mm.668 vs base

This occurred before the merging https://github.com/eclipse-openj9/openj9/pull/19712 at https://github.com/eclipse-openj9/openj9/issues/19703#issue-2351873394

pshipton commented 2 weeks ago

This occurred before the merging https://github.com/eclipse-openj9/openj9/pull/19712 at https://github.com/eclipse-openj9/openj9/issues/19703#issue-2351873394

It doesn't matter. The "fix" will get rid of ArrayIndexOutOfBoundsException but not all the failures.

Here is the javacore content that matches https://github.com/eclipse-openj9/openj9/issues/19703#issuecomment-2173691862.

javacore Current thread history ``` 1XECTHTYPE Current thread history (J9VMThread:0x3CEB6100) 3XEHSTTYPE 15:05:11:118405564 GMT j9dmp.9 - Preparing for dump, filename=/j9tmp/bld_72921_zos_390-31/bld_72921/trace_history/87016273/results/FYREC802-trace_history.pl-m-20240617-080509/javacore.txt 3XEHSTTYPE 15:05:11:117785224 GMT j9bcverify(j9vm).37 - allocating classLoadingConstraints table 3XEHSTTYPE 15:05:11:115339502 GMT sunvmi.98 - JVM_GetSystemPackage(name=3CEB5DA8) 3XEHSTTYPE 15:05:11:115300849 GMT sunvmi.98 - JVM_GetSystemPackage(name=3CEB5E08) 3XEHSTTYPE 15:05:11:113972388 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/jvmtest/VM/com.ibm.jvm.ras.tests/com.ibm.jvm.ras.tests.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:111355887 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=A42C0000 sp=3CEB5F34 a0=3CEB5F40 pc=00000001 literals=00000000 els=19BB45E8 j2i=00000000 3XEHSTTYPE 15:05:11:111355216 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=A42C0000 sp=3CEB5F04 a0=3CEB5F10 pc=00000001 literals=00000000 els=19BB45E8 j2i=00000000 3XEHSTTYPE 15:05:11:111285735 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=1C0C0100 sp=3CEB5E8C a0=3CEB5EA0 pc=00000003 literals=00000000 els=19BB45E8 j2i=00000000 3XEHSTTYPE 15:05:11:111155891 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/traceformat.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:110176390 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmcmsprovider.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:109234340 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/xmlencfw.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:108299710 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/CmpCrmf.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:107291568 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/dtfj.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:105509635 GMT j9scar.140 - JVM_Open(name=/usr/include/java_classes/EZBCPP.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:103858226 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=04300000 sp=3CEB5D48 a0=3CEB5D54 pc=00000001 literals=00000000 els=19BB3588 j2i=00000000 3XEHSTTYPE 15:05:11:103857750 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=041C0000 sp=3CEB5D48 a0=3CEB5D54 pc=00000001 literals=00000000 els=19BB3588 j2i=00000000 3XEHSTTYPE 15:05:11:102287100 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/zertjsse.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:101017500 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmsaslprovider.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:099625952 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmpkcs11impl.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:098725253 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/zosrrs.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:096724023 GMT j9vm.376 - Releasing exclusive VM Access 3XEHSTTYPE 15:05:11:096721476 GMT j9mm.134 - Allocation failure end: newspace=362488/2097152 oldspace=6146296/6291456 loa=314880/314880 3XEHSTTYPE 15:05:11:096716647 GMT j9mm.674 - MSSSS::allocate type Object size 40360 subspace this 197146201bfef1d4/ ,x?? base 1971462000000000 prev 0 shouldCollectOnFailure 426740000 3XEHSTTYPE 15:05:11:096711966 GMT j9mm.150 - avgTimeToStartCollection: 92 avgTimeIdleAfterCollection: 5 avgScanStallTime: 189 avgSyncStallTime: 21 avgNotifyStallTime: 0 3XEHSTTYPE 15:05:11:096663845 GMT j9mm.711 - >[1] MM_Scavenger_calculateRecommendedWorkingThreads entry 3XEHSTTYPE 15:05:11:096662837 GMT j9mm.140 - Tilt ratio: 50 3XEHSTTYPE 15:05:11:096658108 GMT j9mm.545 - Scav 0: stall_work= 0ms stall_complete= 0ms stall_sync= 0ms stall_count=0/0/4 free_lists=9/5 scan_lists=4/4 3XEHSTTYPE 15:05:11:096657884 GMT j9mm.715 - Thread: 0 -> timeToStartCollection: 59 scanStall: 0 syncStall: 36 notifyStall: 1 3XEHSTTYPE 15:05:11:096072271 GMT j9vm.683 - WalkStackFrames - walkThread=3E7ED200 flags=04600002 sp=3E7ED0EC a0=3E7ED0FC pc=00000007 literals=00000000 els=00000000 j2i=00000000 3XEHSTTYPE 15:05:11:096071847 GMT j9vm.683 - WalkStackFrames - walkThread=3EACF200 flags=04600002 sp=3EA7D17C a0=3EA7D18C pc=00000007 literals=00000000 els=00000000 j2i=00000000 3XEHSTTYPE 15:05:11:096071415 GMT j9vm.683 - WalkStackFrames - walkThread=3CEE9E00 flags=04600002 sp=3CEE9D6C a0=3CEE9D7C pc=00000007 literals=00000000 els=00000000 j2i=00000000 3XEHSTTYPE 15:05:11:096070985 GMT j9vm.683 - WalkStackFrames - walkThread=3CEE3500 flags=04600002 sp=3CEE3424 a0=3CEE3434 pc=00000007 literals=00000000 els=00000000 j2i=00000000 3XEHSTTYPE 15:05:11:096070411 GMT j9vm.683 - WalkStackFrames - walkThread=3CECC700 flags=04600002 sp=3CECC634 a0=3CECC644 pc=00000007 literals=00000000 els=00000000 j2i=00000000 3XEHSTTYPE 15:05:11:096069932 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB9A00 flags=04600002 sp=3CEC64C4 a0=3CEC6514 pc=00000007 literals=00000040 els=00000000 j2i=00000000 3XEHSTTYPE 15:05:11:096069142 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=04600002 sp=3CEB5D64 a0=3CEB5D84 pc=3EAFB42D literals=3EC718E8 els=19BB45E8 j2i=00000000 3XEHSTTYPE 15:05:11:096045598 GMT j9mm.540 - Done processing puddle 3E7B2798 (size=1024) 3XEHSTTYPE 15:05:11:095692386 GMT j9mm.539 - Start processing puddle 3E7B2798 3XEHSTTYPE 15:05:11:095636392 GMT j9mm.64 - LocalGC start: globalcount=0 scavengecount=1 weakrefs=0 soft=0 phantom=0 finalizers=0 3XEHSTTYPE 15:05:11:095635595 GMT j9mm.778 - MSSSS::flip set_evacuate 3XEHSTTYPE 15:05:11:095632387 GMT j9mm.467 - Cycle Start: type 2 approximateFreeMemorySize 6146296 3XEHSTTYPE 15:05:11:095626668 GMT j9mm.148 - >Scavenger start 3XEHSTTYPE 15:05:11:095626266 GMT j9mm.193 - MM_GlobalCollector_isTimeForGlobalGCKickoff. dynamicClassUnloading:1 classLoaderBlocks:4 dynamicClassUnloadingKickoffThreshold:80000 lastUnloadNumOfClassLoaders:0 3XEHSTTYPE 15:05:11:095621343 GMT j9mm.135 - Exclusive access: exclusiveaccessms=0.001 meanexclusiveaccessms=0.001 threads=0 lastthreadtid=0x3CEB6788 beatenbyotherthread=0 3XEHSTTYPE 15:05:11:095621066 GMT j9mm.469 - Allocation failure cycle start: newspace=0/2097152 oldspace=6146296/6291456 loa=314880/314880 requestedbytes=40360 3XEHSTTYPE 15:05:11:095619114 GMT j9mm.133 - Allocation failure start: newspace=0/2097152 oldspace=6146296/6291456 loa=314880/314880 requestedbytes=40360 3XEHSTTYPE 15:05:11:095617039 GMT j9vm.371 - Attempting to acquire exclusive VM access. 3XEHSTTYPE 15:05:11:095615077 GMT j9mm.672 - >MSSSS::allocationRequestFailed size 40360 subspace this 197146201bfef1d4/  base 1970fb2000000001 prev 69ce13d500000001 allocationType 426819360 3XEHSTTYPE 15:05:11:095446044 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjcecca.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:094517950 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmxmldsigprovider.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:092802699 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmxmlencprovider.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:091052348 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmkeycert.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:089735885 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/dtfjview.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:088278856 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjcehybrid.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:086798335 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjcefips.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:084623388 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjceprovider.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:083530394 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/gskikm.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:082656040 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmxmlcrypto.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:081107000 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/IBMSecureRandom.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:079232591 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjceplus.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:077890927 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjzos.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:073758395 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=002C0000 sp=3CEB5B34 a0=3CEB5B90 pc=00000006 literals=00000000 els=19BB0E48 j2i=00000000 3XEHSTTYPE 15:05:11:073672997 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=04300000 sp=3CEB5B9C a0=3CEB5BA8 pc=00000001 literals=00000000 els=19BB1EA8 j2i=00000000 3XEHSTTYPE 15:05:11:073672538 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=041C0000 sp=3CEB5B9C a0=3CEB5BA8 pc=00000001 literals=00000000 els=19BB1EA8 j2i=00000000 3XEHSTTYPE 15:05:11:072835334 GMT j9scar.140 - JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/healthcenter.jar, mode=2, flags=0) 3XEHSTTYPE 15:05:11:071362977 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=002C0000 sp=3CEB5BFC a0=3CEB5C10 pc=00000003 literals=00000000 els=19BB34E8 j2i=00000000 3XEHSTTYPE 15:05:11:071298911 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=002C0000 sp=3CEB5BFC a0=3CEB5C10 pc=00000003 literals=00000000 els=19BB34E8 j2i=00000000 3XEHSTTYPE 15:05:11:071230045 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=002C0000 sp=3CEB5BFC a0=3CEB5C10 pc=00000003 literals=00000000 els=19BB34E8 j2i=00000000 3XEHSTTYPE 15:05:11:071164128 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=002C0000 sp=3CEB5BFC a0=3CEB5C10 pc=00000003 literals=00000000 els=19BB34E8 j2i=00000000 3XEHSTTYPE 15:05:11:067883483 GMT j9jcl.326 - com_ibm_tools_attach_javaSE_IPC_isUsingDefaultUid: ACEE acronym: C? aceeflg3Addr = 6fc408 aceeflg3Value = 4 3XEHSTTYPE 15:05:11:067287237 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=002C0000 sp=3CEB5D0C a0=3CEB5D68 pc=00000006 literals=00000000 els=19BB1C88 j2i=00000000 3XEHSTTYPE 15:05:11:065895288 GMT j9vm.683 - WalkStackFrames - walkThread=3CEB6100 flags=002C0200 sp=3CEB5EC4 a0=3CEB5F60 pc=00000006 literals=00000000 els=19BB3C08 j2i=00000000 3XEHSTTYPE 15:05:11:065297580 GMT j9vm.239 - J9RegisterAsyncEvent eventHandler=1C0B6D78 userData=19766520 3XEHSTTYPE 15:05:11:065297136 GMT j9jvmti.401 - HookVMInitializedFirst 3XEHSTTYPE 15:05:11:065295709 GMT j9jvmti.405 - HookVMStarted 3XEHSTTYPE 15:05:11:063158975 GMT j9trc.5 - Thread started VMthread = 3CEB6100, name = main, nativeID = 19959310 ```
Snap.trc content: ``` / Trace Summary Service level: JRE 1.8.0 z/OS s390-31 (build 8.0.9.0 - pmz3180sr9-20240606_01(SR9)) JVM startup options: -Xoptionsfile=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390/default/options.default -Xlockword:mode=default,noLockword=java/lang/String,noLockword=java/util/MapEntry,noLockword=java/util/HashMap$Entry,noLockword=org/apache/harmony/luni/util/ModifiedMap$Entry,noLockword=java/util/Hashtable$Entry,noLockword=java/lang/invoke/MethodType,noLockword=java/lang/invoke/MethodHandle,noLockword=java/lang/invoke/CollectHandle,noLockword=java/lang/invoke/ConstructorHandle,noLockword=java/lang/invoke/ConvertHandle,noLockword=java/lang/invoke/ArgumentConversionHandle,noLockword=java/lang/invoke/AsTypeHandle,noLockword=java/lang/invoke/ExplicitCastHandle,noLockword=java/lang/invoke/FilterReturnHandle,noLockword=java/lang/invoke/DirectHandle,noLockword=java/lang/invoke/ReceiverBoundHandle,noLockword=java/lang/invoke/DynamicInvokerHandle,noLockword=java/lang/invoke/FieldHandle,noLockword=java/lang/invoke/FieldGetterHandle,noLockword=java/lang/invoke/FieldSetterHandle,noLockword=java/lang/invoke/StaticFieldGetterHandle,noLockword=java/lang/invoke/StaticFieldSetterHandle,noLockword=java/lang/invoke/IndirectHandle,noLockword=java/lang/invoke/InterfaceHandle,noLockword=java/lang/invoke/VirtualHandle,noLockword=java/lang/invoke/PrimitiveHandle,noLockword=java/lang/invoke/InvokeExactHandle,noLockword=java/lang/invoke/InvokeGenericHandle,noLockword=java/lang/invoke/VarargsCollectorHandle,noLockword=java/lang/invoke/ThunkTuple -Djava.lang.stringBuffer.growAggressively=false -XX:+OriginalJDK8HeapSizeCompatibilityMode -XX:+LegacyXlogOption -XX:+EnsureHashed:java/lang/Class,java/lang/Thread -XX:+EnableExtendedHCR -Xjcl:jclse29 -Dcom.ibm.oti.vm.bootstrap.library.path=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390/default:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390 -Dsun.boot.library.path=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390/default:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390 -Djava.library.path=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390/default:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390/default:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390/j9vm:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/../lib/s390:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre//lib/icc:/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/s390:.:/usr/lib:/rsusr/rocket/lib/perl5/5.24.0/os390/CORE:/perlv5240/lib/perl5/5.24.0/os390/CORE:/usr/lpp/perl/lib/5.8.7/os390-thread-multi/CORE -Djava.home=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre -Djava.ext.dirs=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext -Duser.dir=/j9tmp/bld_72921_zos_390-31/bld_72921/trace_history/87016273/results/FYREC802-trace_history.pl-m-20240617-080509 -Djava.class.path=. -Xdump:none -Xdump:java:file=javacore.txt -Xdump:snap:file=snap.trc -Djava.class.path=/j9vm/ebcdic/builds/bld_72921/jvmtest/VM/rastest/trace/trace_history/../../../com.ibm.jvm.ras.tests/com.ibm.jvm.ras.tests.jar -Xnocompressedrefs -Dsun.java.command=com.ibm.trace.tests.apptrace.GenerateJavaCoreAndSnap -Dsun.java.launcher=SUN_STANDARD Processor information: Arch family: S390 Processor Sub-type: ESA Num Processors: 2 Big Endian: true Word size: 32 Using Trace Counter: J9 timer Trace activation information:: FORMAT=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib;. MAXIMAL=all{level1} EXCEPTION=j9mm{gclogger} Trace file header: JVM start time: 15:05:10.939000000 Generations: 0 Pointer size: 4 Active threads 0x00000000 Exception trace pseudo-thread 0x3eda1500 (unnamed thread) 0x3ceb9a00 (unnamed thread) 0x3ceb6100 main 0x3eacf200 (unnamed thread) 0x3cecc700 (unnamed thread) 0x3e7ed200 (unnamed thread) 0x3cee9e00 (unnamed thread) 0x3cee3500 (unnamed thread) Trace Formatted Data Time (UTC) Thread ID Tracepoint ID Type Tracepoint Data 15:05:11.065586521 *0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x2c0000 sp=0x3ceb5d0c a0=0x3ceb5d68 pc=0x6 literals=0x0 els=0x19bb1c88 j2i=0x0 15:05:11.066975083 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x2c0000 sp=0x3ceb5bfc a0=0x3ceb5c10 pc=0x3 literals=0x0 els=0x19bb34e8 j2i=0x0 15:05:11.070842540 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x2c0000 sp=0x3ceb5bfc a0=0x3ceb5c10 pc=0x3 literals=0x0 els=0x19bb34e8 j2i=0x0 15:05:11.070908297 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x2c0000 sp=0x3ceb5bfc a0=0x3ceb5c10 pc=0x3 literals=0x0 els=0x19bb34e8 j2i=0x0 15:05:11.070976995 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x2c0000 sp=0x3ceb5bfc a0=0x3ceb5c10 pc=0x3 literals=0x0 els=0x19bb34e8 j2i=0x0 15:05:11.071040905 0x3ceb6100 j9vm.683 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/healthcenter.jar, mode=2, flags=0) 15:05:11.072509679 0x3ceb6100 j9scar.140 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x41c0000 sp=0x3ceb5b9c a0=0x3ceb5ba8 pc=0x1 literals=0x0 els=0x19bb1ea8 j2i=0x0 15:05:11.073344846 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x4300000 sp=0x3ceb5b9c a0=0x3ceb5ba8 pc=0x1 literals=0x0 els=0x19bb1ea8 j2i=0x0 15:05:11.073345304 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x2c0000 sp=0x3ceb5b34 a0=0x3ceb5b90 pc=0x6 literals=0x0 els=0x19bb0e48 j2i=0x0 15:05:11.073430495 0x3ceb6100 j9vm.683 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjzos.jar, mode=2, flags=0) 15:05:11.077552971 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjceplus.jar, mode=2, flags=0) 15:05:11.078891370 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/IBMSecureRandom.jar, mode=2, flags=0) 15:05:11.080761219 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmxmlcrypto.jar, mode=2, flags=0) 15:05:11.082306489 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/gskikm.jar, mode=2, flags=0) 15:05:11.083178716 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjceprovider.jar, mode=2, flags=0) 15:05:11.084269051 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjcefips.jar, mode=2, flags=0) 15:05:11.086438705 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjcehybrid.jar, mode=2, flags=0) 15:05:11.087915624 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/dtfjview.jar, mode=2, flags=0) 15:05:11.089369108 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmkeycert.jar, mode=2, flags=0) 15:05:11.090682367 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmxmlencprovider.jar, mode=2, flags=0) 15:05:11.092428458 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmxmldsigprovider.jar, mode=2, flags=0) 15:05:11.094139536 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmjcecca.jar, mode=2, flags=0) 15:05:11.095065372 0x3ceb6100 j9scar.140 Exit MSSSS::allocationRequestFailed size 40360 subspace this 0x197146201bfef1d4/ ?? base 0x1970fb2000000001 prev 0x69ce13d500000001 allocationType 426819360 15:05:11.095234686 0x3ceb6100 j9vm.361 Entry >Attempting to acquire exclusive VM access. 15:05:11.095234858 0x3ceb6100 j9vm.366 Event First thread to try for exclusive access. Setting the exclusive access state to J9_XACCESS_PENDING 15:05:11.095235592 0x3ceb6100 j9vm.368 Event Posted Halt request to 0 threads. 15:05:11.095235718 0x3ceb6100 j9vm.369 Event Waiting for 0 thread halt responses. 15:05:11.095235785 0x3ceb6100 j9vm.425 Event Waiting for 0 thread JNI critical region responses. 15:05:11.095235841 0x3ceb6100 j9vm.370 Event Changing exclusiveAccessState to J9_XACCESS_EXCLUSIVE. 15:05:11.095235951 0x3ceb6100 j9vm.371 Exit MM_GlobalCollector_isTimeForGlobalGCKickoff. dynamicClassUnloading:1 classLoaderBlocks:4 dynamicClassUnloadingKickoffThreshold:80000 lastUnloadNumOfClassLoaders:0 15:05:11.095245155 0x3ceb6100 j9mm.193 Exit Scavenger start 15:05:11.095251261 0x3ceb6100 j9mm.467 Event Cycle Start: type 2 approximateFreeMemorySize 6146296 15:05:11.095254462 0x3ceb6100 j9mm.778 Event MSSSS::flip set_evacuate 15:05:11.095255257 0x3ceb6100 j9mm.64 Event LocalGC start: globalcount=0 scavengecount=1 weakrefs=0 soft=0 phantom=0 finalizers=0 15:05:11.095311115 0x3ceb6100 j9mm.539 Event Start processing puddle 0x3e7b2798 15:05:11.095663467 0x3ceb6100 j9mm.540 Event Done processing puddle 0x3e7b2798 (size=1024) 15:05:11.095665957 0x3ceb6100 j9vm.682 Entry >WalkStackFrames - walkThread=0x3ceb6100 flags=0x4600002 sp=0x3ceb5d64 a0=0x3ceb5d84 pc=0x3eafb42d literals=0x3ec718e8 els=0x19bb45e8 j2i=0x0 15:05:11.095686954 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb9a00 flags=0x4600002 sp=0x3cec64c4 a0=0x3cec6514 pc=0x7 literals=0x40 els=0x0 j2i=0x0 15:05:11.095687741 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3cecc700 flags=0x4600002 sp=0x3cecc634 a0=0x3cecc644 pc=0x7 literals=0x0 els=0x0 j2i=0x0 15:05:11.095688220 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3cee3500 flags=0x4600002 sp=0x3cee3424 a0=0x3cee3434 pc=0x7 literals=0x0 els=0x0 j2i=0x0 15:05:11.095688793 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3cee9e00 flags=0x4600002 sp=0x3cee9d6c a0=0x3cee9d7c pc=0x7 literals=0x0 els=0x0 j2i=0x0 15:05:11.095689221 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3eacf200 flags=0x4600002 sp=0x3ea7d17c a0=0x3ea7d18c pc=0x7 literals=0x0 els=0x0 j2i=0x0 15:05:11.095689652 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3e7ed200 flags=0x4600002 sp=0x3e7ed0ec a0=0x3e7ed0fc pc=0x7 literals=0x0 els=0x0 j2i=0x0 15:05:11.095690075 0x3ceb6100 j9vm.683 Exit timeToStartCollection: 59 scanStall: 0 syncStall: 36 notifyStall: 1 15:05:11.096274487 0x3ceb6100 j9mm.545 Event Scav 0: stall_work= 0ms stall_complete= 0ms stall_sync= 0ms stall_count=0/0/4 free_lists=9/5 scan_lists=4/4 15:05:11.096279205 0x3ceb6100 j9mm.140 Event Tilt ratio: 50 15:05:11.096280210 0x3ceb6100 j9mm.711 Entry >[1] MM_Scavenger_calculateRecommendedWorkingThreads entry 15:05:11.096280636 0x3ceb6100 j9mm.714 Event Average for: 2 threads -> avgTimeToStartCollection: 92 avgTimeIdleAfterCollection: 5 avgScanStallTime: 189 avgSyncStallTime: 21 avgNotifyStallTime: 0 15:05:11.096282715 0x3ceb6100 j9mm.713 Exit MSSSS::allocate type Object size 40360 subspace this 0x197146201bfef1d4/ ,x?? p? base 0x1971462000000000 prev 0x0 shouldCollectOnFailure 426740000 15:05:11.096328838 0x3ceb6100 j9mm.669 Event MSSSS::allocate type Object size 40360 event 3 15:05:11.096330678 0x3ceb6100 j9mm.671 Exit Releasing exclusive VM Access 15:05:11.096338411 0x3ceb6100 j9vm.375 Event Exclusive VM Access queue is empty, resetting exclusive access state and notifying all halted threads. Changing exclusiveAccessState to J9_XACCESS_NONE. 15:05:11.096340242 0x3ceb6100 j9vm.376 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/zosrrs.jar, mode=2, flags=0) 15:05:11.098336602 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmpkcs11impl.jar, mode=2, flags=0) 15:05:11.099235109 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmsaslprovider.jar, mode=2, flags=0) 15:05:11.100623271 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/zertjsse.jar, mode=2, flags=0) 15:05:11.101889782 0x3ceb6100 j9scar.140 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x41c0000 sp=0x3ceb5d48 a0=0x3ceb5d54 pc=0x1 literals=0x0 els=0x19bb3588 j2i=0x0 15:05:11.103456611 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x4300000 sp=0x3ceb5d48 a0=0x3ceb5d54 pc=0x1 literals=0x0 els=0x19bb3588 j2i=0x0 15:05:11.103457085 0x3ceb6100 j9vm.683 Exit JVM_Open(name=/usr/include/java_classes/EZBCPP.jar, mode=2, flags=0) 15:05:11.105104476 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/dtfj.jar, mode=2, flags=0) 15:05:11.106882073 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/CmpCrmf.jar, mode=2, flags=0) 15:05:11.107887761 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/xmlencfw.jar, mode=2, flags=0) 15:05:11.108820118 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/ibmcmsprovider.jar, mode=2, flags=0) 15:05:11.109759876 0x3ceb6100 j9scar.140 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/sdk/mz3180/jre/lib/ext/traceformat.jar, mode=2, flags=0) 15:05:11.110736994 0x3ceb6100 j9scar.140 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0x1c0c0100 sp=0x3ceb5e8c a0=0x3ceb5ea0 pc=0x3 literals=0x0 els=0x19bb45e8 j2i=0x0 15:05:11.110866521 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0xa42c0000 sp=0x3ceb5f04 a0=0x3ceb5f10 pc=0x1 literals=0x0 els=0x19bb45e8 j2i=0x0 15:05:11.110935833 0x3ceb6100 j9vm.683 Exit WalkStackFrames - walkThread=0x3ceb6100 flags=0xa42c0000 sp=0x3ceb5f34 a0=0x3ceb5f40 pc=0x1 literals=0x0 els=0x19bb45e8 j2i=0x0 15:05:11.110936503 0x3ceb6100 j9vm.683 Exit JVM_Open(name=/j9vm/ebcdic/builds/bld_72921/jvmtest/VM/com.ibm.jvm.ras.tests/com.ibm.jvm.ras.tests.jar, mode=2, flags=0) 15:05:11.113546637 0x3ceb6100 j9scar.140 Exit JVM_GetSystemPackage(name=0x3ceb5e08) 15:05:11.114870955 0x3ceb6100 sunvmi.95 Event Searching for package com/ibm/trace/tests/apptrace/ (len=29) 15:05:11.114871866 0x3ceb6100 sunvmi.98 Exit JVM_GetSystemPackage(name=0x3ceb5da8) 15:05:11.114910179 0x3ceb6100 sunvmi.95 Event Searching for package com/ibm/trace/tests/apptrace/ (len=29) 15:05:11.114910425 0x3ceb6100 sunvmi.98 Exit
pshipton commented 2 weeks ago

Seems like an EBCDIC conversion problem.

Snap: 15:05:11.096328626 0x3ceb6100 j9mm.668 Entry >MSSSS::allocate type Object size 40360 subspace this 0x197146201bfef1d4/� ,x�?? �p? base 0x1971462000000000 prev 0x0 shouldCollectOnFailure 426740000

javacore: 3XEHSTTYPE 15:05:11:096712379 GMT j9mm.668 - >MSSSS::allocate type Object size 40360 subspace this 197146201bfef1d4/ ,x?? base 1971462000000000 prev 0 shouldCollectOnFailure 426740000

pshipton commented 2 weeks ago

Also the format is different. In the formatted Snap you get 0x0 and javacore you get 0.

keithc-ca commented 2 weeks ago

I think the tracepoint is misused or ill-defined

TraceEntry=Trc_MM_MSSSS_allocate_entry Overhead=1 Level=1 Group=allocate Template="MSSSS::allocate type %s size %zu subspace this %llx/%s base %llx prev %llx shouldCollectOnFailure %zu"

The third argument is expected to be %llx, but is only provided a (32-bit) pointer (where it fails):

    Trc_MM_MSSSS_allocate_entry(env->getLanguageVMThread(), "Object", allocDescription->getBytesRequested(), this, getName(), baseSubSpace, previousSubSpace, (uintptr_t)shouldCollectOnFailure);

The template should have used %zx instead of %llx, but rather than change the template, we can fix the use.

keithc-ca commented 2 weeks ago

On the other hand, changing the template, would correct the interpretation of existing trace data.

amicic commented 2 weeks ago

Correct, it should be %zx (not only that one, but at a few other similar places). I can (and prefer to) fix format.

keithc-ca commented 2 weeks ago

I can (and prefer to) fix format.

Should we interpret that to mean that you will create pull requests to fix them?

dmitripivkine commented 2 weeks ago

I can (and prefer to) fix format.

Should we interpret that to mean that you will create pull requests to fix them?

https://github.com/eclipse/omr/pull/7381

JasonFengJ9 commented 2 weeks ago

Passed in recent builds.

pshipton commented 1 week ago

@amicic do you want to add https://github.com/eclipse/omr/pull/7381 to the 0.46 release?

amicic commented 1 week ago

@amicic do you want to add eclipse/omr#7381 to the 0.46 release?

https://github.com/eclipse-openj9/openj9-omr/pull/210