pshipton
commented
2 months ago Test case
public class MaxChar {
private final static int MAX_UTF16_STRING_LENGTH = Integer.MAX_VALUE / 2;
private static char[] generateCharData(int size) {
char[] nonAscii = "\u0100".toCharArray();
char[] arr = new char[size];
System.arraycopy(nonAscii, 0, arr, 0, nonAscii.length); // non-latin1 at start
return arr;
}
public static void main(String[] args) throws Throwable {
final char[] large_char_array = generateCharData(MAX_UTF16_STRING_LENGTH + 1);
int[] sizes = new int[] {
MAX_UTF16_STRING_LENGTH + 1,
MAX_UTF16_STRING_LENGTH,
MAX_UTF16_STRING_LENGTH - 1};
for (int size : sizes) {
try {
new String(large_char_array, 0, size);
if (size >= MAX_UTF16_STRING_LENGTH) {
System.out.println("Expected OOM for " + size);
}
} catch (OutOfMemoryError e) {
System.out.println(e);
}
}
}
}When running with -Xcomp (-Xjit:count=0) on at least aarch64 or x86, the OOM which is expected for size 1073741823 doesn't occur. It didn't fail on zlinux, some platforms (AIX, Windows) didn't run.
@hzongaro pls take a look
hzongaro
https://openj9-jenkins.osuosl.org/job/Test_openjdk23_j9_sanity.openjdk_aarch64_mac_Nightly_testList_0/13/ jdk_lang_1 (-XX:-UseCompressedOops)
-Xcomp (-Xjit:count=0) -Xmx8gjava/lang/String/CompactString/MaxSizeUTF16String.javahttps://openj9-jenkins.osuosl.org/job/Test_openjdk23_j9_sanity.openjdk_x86-64_linux_Nightly_testList_1/38/ jdk_lang_1
https://openj9-jenkins.osuosl.org/job/Test_openjdk23_j9_sanity.openjdk_x86-64_mac_Nightly_testList_0/11 jdk_lang_0, jdk_lang_j9_0 https://openj9-jenkins.osuosl.org/job/Test_openjdk23_j9_sanity.openjdk_x86-64_mac_Nightly_testList_1/11/ jdk_lang_1