eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.29k stars 722 forks source link

WIP: Change J9::VMMethodEnv::startPC error return value #20657

Open IBMJimmyk opened 5 days ago

IBMJimmyk commented 5 days ago

OMR version of startPC expects either a valid start PC or 0 to be returned from J9::VMMethodEnv::startPC since it isn't aware of the J9 specific non-startPC special values that are currently being returned.

This change checks if the J9_STARTPC_NOT_TRANSLATED bit flag is set on the startPC to be returned. This indicates that it isn't a real startPC and will return 0 instead.

Related to: https://github.com/eclipse-omr/omr/pull/7550 They don't need to go in at the same time since this is currently broken and both PRs are needed to fix the issue. Checking in OpenJ9 or OMR first won't make the problem worse.