search

eclipse-openj9 / openj9

Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.
Other
3.28k stars 721 forks source link

Newly enabled jvmti tests should be renamed (remove extended from name) #2147

Open smlambert opened 6 years ago

smlambert commented 6 years ago

Some jvmti tests are named jvmti_extended but are tagged as "sanity" level. In general, we should avoid using the level in the name of a test, as it is confusing when it doesn't match the level its in, and it makes for more changes if we wish to move a test into a different level.

llxia commented 6 years ago

https://github.com/eclipse/openj9/blob/ef9a7abd00e1b27888e79645ba1a8723707e5155/test/functional/cmdLineTests/jvmtitests/playlist.xml#L165

llxia commented 6 years ago

This file already has a test named cmdLineTester_jvmtitests. We cannot simply remove _extended as our current infrastructure does not support test with same name and subsets. I will update the level to extended, so it matches with the name.

Please let me know if there is any other suggestion for the name.

pshipton commented 6 years ago

We should keep the tests as sanity as they have been traditionally run in sanity.

The group seems to only consist of 2 tests, rc015 and rc016. rc016 mentions HCR extended mode so perhaps that could exlain the name. These tests run in modes with jdwp enabled, so perhaps call them "_debug".

pshipton commented 6 years ago

@gacholio any suggestions how we can rename cmdLineTester_jvmtitests_extended so its not confused with extended (vs sanity) testing? See the last 2 comments.

gacholio commented 6 years ago

I'd agree to rename them to debug, or just roll them into one of the other buckets.

llxia commented 6 years ago

Thanks. I will change the name to cmdLineTester_jvmtitests_debug and disable the test until #2129 is resolved. We can roll this test into one of the other buckets when it is all clear.